They are no more. No functional change.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Michal Orzel <michal.orzel@amd.com>
CC: Oleksii Kurochko <oleksii.kurochko@gmail.com>
CC: Shawn Anastasio <sanastasio@raptorengineering.com>
---
xen/arch/arm/include/asm/bitops.h | 2 --
xen/arch/ppc/include/asm/bitops.h | 2 --
xen/arch/x86/include/asm/bitops.h | 2 --
xen/include/xen/bitops.h | 17 -----------------
4 files changed, 23 deletions(-)
diff --git a/xen/arch/arm/include/asm/bitops.h b/xen/arch/arm/include/asm/bitops.h
index 3c023103f734..91cd167b6bbb 100644
--- a/xen/arch/arm/include/asm/bitops.h
+++ b/xen/arch/arm/include/asm/bitops.h
@@ -86,8 +86,6 @@ bool clear_mask16_timeout(uint16_t mask, volatile void *p,
*/
#define hweight64(x) generic_hweight64(x)
#define hweight32(x) generic_hweight32(x)
-#define hweight16(x) generic_hweight16(x)
-#define hweight8(x) generic_hweight8(x)
#endif /* _ARM_BITOPS_H */
/*
diff --git a/xen/arch/ppc/include/asm/bitops.h b/xen/arch/ppc/include/asm/bitops.h
index 6e4e112b8b92..64512e949530 100644
--- a/xen/arch/ppc/include/asm/bitops.h
+++ b/xen/arch/ppc/include/asm/bitops.h
@@ -134,7 +134,5 @@ static inline int test_and_set_bit(unsigned int nr, volatile void *addr)
*/
#define hweight64(x) __builtin_popcountll(x)
#define hweight32(x) __builtin_popcount(x)
-#define hweight16(x) __builtin_popcount((uint16_t)(x))
-#define hweight8(x) __builtin_popcount((uint8_t)(x))
#endif /* _ASM_PPC_BITOPS_H */
diff --git a/xen/arch/x86/include/asm/bitops.h b/xen/arch/x86/include/asm/bitops.h
index 8c0403405aa2..4c5b21907a64 100644
--- a/xen/arch/x86/include/asm/bitops.h
+++ b/xen/arch/x86/include/asm/bitops.h
@@ -483,7 +483,5 @@ static always_inline unsigned int arch_flsl(unsigned long x)
*/
#define hweight64(x) generic_hweight64(x)
#define hweight32(x) generic_hweight32(x)
-#define hweight16(x) generic_hweight16(x)
-#define hweight8(x) generic_hweight8(x)
#endif /* _X86_BITOPS_H */
diff --git a/xen/include/xen/bitops.h b/xen/include/xen/bitops.h
index 6f8e36f1c755..58c600155f7e 100644
--- a/xen/include/xen/bitops.h
+++ b/xen/include/xen/bitops.h
@@ -413,23 +413,6 @@ static inline unsigned int generic_hweight32(unsigned int w)
return (w + (w >> 16)) & 0xff;
}
-static inline unsigned int generic_hweight16(unsigned int w)
-{
- w -= ((w >> 1) & 0x5555);
- w = (w & 0x3333) + ((w >> 2) & 0x3333);
- w = (w + (w >> 4)) & 0x0f0f;
-
- return (w + (w >> 8)) & 0xff;
-}
-
-static inline unsigned int generic_hweight8(unsigned int w)
-{
- w -= ((w >> 1) & 0x55);
- w = (w & 0x33) + ((w >> 2) & 0x33);
-
- return (w + (w >> 4)) & 0x0f;
-}
-
static inline unsigned int generic_hweight64(uint64_t w)
{
if ( BITS_PER_LONG < 64 )
--
2.39.2
Hi Andrew, On 9/4/24 5:55 PM, Andrew Cooper wrote: > They are no more. No functional change. > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> > Acked-by: Jan Beulich <jbeulich@suse.com> For the PPC parts: Acked-by: Shawn Anastasio <sanastasio@raptorengineering.com> Thanks, Shawn
On 9/13/24 9:56 AM, Shawn Anastasio wrote: > Hi Andrew, > > On 9/4/24 5:55 PM, Andrew Cooper wrote: >> They are no more. No functional change. >> >> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> >> Acked-by: Jan Beulich <jbeulich@suse.com> > > For the PPC parts: > > Acked-by: Shawn Anastasio <sanastasio@raptorengineering.com> My apologies, it seems these were already merged. Excuse the noise. Thanks, Shawn
On Wed, 4 Sep 2024, Andrew Cooper wrote: > They are no more. No functional change. > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> > Acked-by: Jan Beulich <jbeulich@suse.com> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
© 2016 - 2024 Red Hat, Inc.