[XEN PATCH v2 0/2] libxl: Implement QEMU command line probe

Anthony PERARD posted 2 patches 2 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20240830094937.40476-1-anthony.perard@vates.tech
tools/libs/light/libxl_dm.c       | 90 +++++++++++++++++++++++++------
tools/libs/light/libxl_internal.h |  6 +++
2 files changed, 80 insertions(+), 16 deletions(-)
[XEN PATCH v2 0/2] libxl: Implement QEMU command line probe
Posted by Anthony PERARD 2 months, 3 weeks ago
Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.libxl-qemu-cmdline-probe-v2

v2:
- removed commited patch
- rename "qemu_cmdline" to "qemu_opts" in struct field and func parameters.
- rename "struct libxl__qemu_available_cmd_line" to
  "struct libxl__qemu_available_opts".

Starting with QEMU 9.0, the option "-chroot", that we use for the
"dmrestrict" feature, is removed. We need to find out which to use
between "-chroot" and "-run-with chroot=dir".

Also, "-runas" is deprecated in QEMU 9.1 and will be remove in a future
release, it's replaced with "-run-with user=user".

To find out which command line option we can use, we'll spawn QEMU, and run the
QMP command "query-command-line-options".

Some example of running these patches:
    with qemu-xen (8.0):
        http://logs.test-lab.xenproject.org/osstest/logs/187352/
    with QEMU (upstream, 9.1-rc3):
        http://logs.test-lab.xenproject.org/osstest/logs/187353/

Anthony PERARD (2):
  libxl: Probe QEMU for -run-with chroot=dir and use it
  libxl: Probe QEMU for -run-with user=user and use it

 tools/libs/light/libxl_dm.c       | 90 +++++++++++++++++++++++++------
 tools/libs/light/libxl_internal.h |  6 +++
 2 files changed, 80 insertions(+), 16 deletions(-)

-- 


Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech
Re: [XEN PATCH v2 0/2] libxl: Implement QEMU command line probe
Posted by Andrew Cooper 2 months, 3 weeks ago
On 30/08/2024 10:49 am, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.libxl-qemu-cmdline-probe-v2
>
> v2:
> - removed commited patch
> - rename "qemu_cmdline" to "qemu_opts" in struct field and func parameters.
> - rename "struct libxl__qemu_available_cmd_line" to
>   "struct libxl__qemu_available_opts".
>
> Starting with QEMU 9.0, the option "-chroot", that we use for the
> "dmrestrict" feature, is removed. We need to find out which to use
> between "-chroot" and "-run-with chroot=dir".
>
> Also, "-runas" is deprecated in QEMU 9.1 and will be remove in a future
> release, it's replaced with "-run-with user=user".
>
> To find out which command line option we can use, we'll spawn QEMU, and run the
> QMP command "query-command-line-options".
>
> Some example of running these patches:
>     with qemu-xen (8.0):
>         http://logs.test-lab.xenproject.org/osstest/logs/187352/
>     with QEMU (upstream, 9.1-rc3):
>         http://logs.test-lab.xenproject.org/osstest/logs/187353/
>
> Anthony PERARD (2):
>   libxl: Probe QEMU for -run-with chroot=dir and use it
>   libxl: Probe QEMU for -run-with user=user and use it
>
>  tools/libs/light/libxl_dm.c       | 90 +++++++++++++++++++++++++------
>  tools/libs/light/libxl_internal.h |  6 +++
>  2 files changed, 80 insertions(+), 16 deletions(-)

I've committed these as they're fully reviewed, but I think this
warrants a CHANGELOG.md update as we're fixing libxl to work with newer
QEMU.

~Andrew