tools/ocaml: Incremental build fixes

[PATCH 0/3] tools/ocaml: Incremental build fixes

Posted by Andrew Cooper 3 months ago

Various extra build bugfixes found while reviewing the `Stabilize Oxenstored's
interface with` series.

Andrew Cooper (3):
  tools/ocaml: Drop OCAMLOPTFLAG_G invocation
  tools/ocaml: Drop o= rune
  tools/ocaml: Fix the version embedded in META files

 tools/ocaml/Makefile.rules | 5 +++--
 tools/ocaml/common.make    | 7 ++-----
 2 files changed, 5 insertions(+), 7 deletions(-)


base-commit: 5231765a4e6528a3208e49885b9eeff42519a6c1
-- 
2.39.2

Re: [PATCH 0/3] tools/ocaml: Incremental build fixes

Posted by Christian Lindig 3 months ago


> On 23 Aug 2024, at 11:51, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> 
> Various extra build bugfixes found while reviewing the `Stabilize Oxenstored's
> interface with` series.
> 
> Andrew Cooper (3):
>  tools/ocaml: Drop OCAMLOPTFLAG_G invocation
>  tools/ocaml: Drop o= rune
>  tools/ocaml: Fix the version embedded in META files
> 
> tools/ocaml/Makefile.rules | 5 +++--
> tools/ocaml/common.make    | 7 ++-----
> 2 files changed, 5 insertions(+), 7 deletions(-)
> 
> 
> base-commit: 5231765a4e6528a3208e49885b9eeff42519a6c1
> -- 
> 2.39.2
> 

Acked-by: Christian Lindig <christian.lindig@cloud.com>

Re: [PATCH 0/3] tools/ocaml: Incremental build fixes

Posted by Edwin Torok 3 months ago

The Makefile changes look fine to me as well.

Reviewed-by: Edwin Török <edwin.torok@cloud.com>

On Fri, Aug 23, 2024 at 11:53 AM Christian Lindig
<christian.lindig@cloud.com> wrote:
>
>
>
> > On 23 Aug 2024, at 11:51, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> >
> > Various extra build bugfixes found while reviewing the `Stabilize Oxenstored's
> > interface with` series.
> >
> > Andrew Cooper (3):
> >  tools/ocaml: Drop OCAMLOPTFLAG_G invocation
> >  tools/ocaml: Drop o= rune
> >  tools/ocaml: Fix the version embedded in META files
> >
> > tools/ocaml/Makefile.rules | 5 +++--
> > tools/ocaml/common.make    | 7 ++-----
> > 2 files changed, 5 insertions(+), 7 deletions(-)
> >
> >
> > base-commit: 5231765a4e6528a3208e49885b9eeff42519a6c1
> > --
> > 2.39.2
> >
>
> Acked-by: Christian Lindig <christian.lindig@cloud.com>
>