Use getopt_long() to handle command line arguments.
Introduce ext_err for common errors exit.
Introducing usage() to handle usage\help messages in a common block.
Signed-off-by: Fouad Hilly <fouad.hilly@cloud.com>
---
[v7]
1- Fix Usage message format.
2- Remove generic error message from ext_err and add specific error messages for "unknown option" and missing "microcode file".
3- Update "microcode file" -> "microcode-file" to remove ambiguity.
[v6]
1- Update usage() printed message format: [microcode file] [options] -> [microcode file | options]
2- Add missing blanks in switch ( opt )
[v5]
1- Update message description.
2- re-arrange static and automatic variables.
3- Fix indentations.
4- reverted the deletion of show-cpu-info for backwards compatibility.
[v4]
1- Merge three patches into one.
2- usage() to print messages to the correct stream.
3- Update commit message and description.
---
tools/misc/xen-ucode.c | 54 +++++++++++++++++++++++++++++++++++-------
1 file changed, 46 insertions(+), 8 deletions(-)
diff --git a/tools/misc/xen-ucode.c b/tools/misc/xen-ucode.c
index 390969db3d1c..bfc1e74dd5cc 100644
--- a/tools/misc/xen-ucode.c
+++ b/tools/misc/xen-ucode.c
@@ -11,6 +11,7 @@
#include <sys/stat.h>
#include <fcntl.h>
#include <xenctrl.h>
+#include <getopt.h>
static xc_interface *xch;
@@ -71,12 +72,30 @@ static void show_curr_cpu(FILE *f)
}
}
+static void usage(FILE *stream, const char *name)
+{
+ fprintf(stream,
+ "%s: Xen microcode updating tool\n"
+ "Usage: %s [options | microcode-file]\n"
+ "options:\n"
+ " -h, --help display this help\n"
+ " -s, --show-cpu-info show CPU information\n",
+ name, name);
+ show_curr_cpu(stream);
+}
+
int main(int argc, char *argv[])
{
+ static const struct option options[] = {
+ {"help", no_argument, NULL, 'h'},
+ {"show-cpu-info", no_argument, NULL, 's'},
+ {NULL, no_argument, NULL, 0}
+ };
int fd, ret;
char *filename, *buf;
size_t len;
struct stat st;
+ int opt;
xch = xc_interface_open(NULL, NULL, 0);
if ( xch == NULL )
@@ -86,22 +105,37 @@ int main(int argc, char *argv[])
exit(1);
}
- if ( argc < 2 )
+ while ( (opt = getopt_long(argc, argv, "hs", options, NULL)) != -1 )
{
- fprintf(stderr,
- "xen-ucode: Xen microcode updating tool\n"
- "Usage: %s [<microcode file> | show-cpu-info]\n", argv[0]);
- show_curr_cpu(stderr);
- exit(2);
+ switch ( opt )
+ {
+ case 'h':
+ usage(stdout, argv[0]);
+ exit(EXIT_SUCCESS);
+
+ case 's':
+ show_curr_cpu(stdout);
+ exit(EXIT_SUCCESS);
+
+ default:
+ fprintf(stderr, "%s: unknown option\n", argv[0]);
+ goto ext_err;
+ }
}
- if ( !strcmp(argv[1], "show-cpu-info") )
+ if ( optind == argc ) {
+ fprintf(stderr, "%s: missing microcode file\n", argv[0]);
+ goto ext_err;
+ }
+
+ /* For backwards compatibility to the pre-getopt() cmdline handling */
+ if ( !strcmp(argv[optind], "show-cpu-info") )
{
show_curr_cpu(stdout);
return 0;
}
- filename = argv[1];
+ filename = argv[optind];
fd = open(filename, O_RDONLY);
if ( fd < 0 )
{
@@ -146,4 +180,8 @@ int main(int argc, char *argv[])
close(fd);
return 0;
+
+ ext_err:
+ usage(stderr, argv[0]);
+ exit(EXIT_FAILURE);
}
--
2.42.0