Non-PCI platform devices may use the ITS. Dom0 Linux drivers for such
devices are failing to register IRQs due to a missing #msi-cells
property. Add the missing #msi-cells property.

Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>
---
See Linux dc4dae00d82f ("Docs: dt: add #msi-cells to GICv3 ITS binding")
---
 xen/arch/arm/gic-v3-its.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c
index 8afcd9783bc8..55bed3fe87d0 100644
--- a/xen/arch/arm/gic-v3-its.c
+++ b/xen/arch/arm/gic-v3-its.c
@@ -951,6 +951,10 @@ int gicv3_its_make_hwdom_dt_nodes(const struct domain *d,
         if ( res )
             return res;
 
+        res = fdt_property_cell(fdt, "#msi-cells", 1);
+        if ( res )
+            return res;
+
         if ( its->phandle )
         {
             res = fdt_property_cell(fdt, "phandle", its->phandle);

base-commit: 984cb316cb27b53704c607e640a7dd2763b898ab
-- 
2.45.2

Hi Stewart,

> On 2 Aug 2024, at 7:26 PM, Stewart Hildebrand <Stewart.Hildebrand@amd.com> wrote:
> 
> Non-PCI platform devices may use the ITS. Dom0 Linux drivers for such
> devices are failing to register IRQs due to a missing #msi-cells
> property. Add the missing #msi-cells property.
> 
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>

Reviewed-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul

> ---
> See Linux dc4dae00d82f ("Docs: dt: add #msi-cells to GICv3 ITS binding")
> ---
> xen/arch/arm/gic-v3-its.c | 4 ++++
> 1 file changed, 4 insertions(+)
> 
> diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c
> index 8afcd9783bc8..55bed3fe87d0 100644
> --- a/xen/arch/arm/gic-v3-its.c
> +++ b/xen/arch/arm/gic-v3-its.c
> @@ -951,6 +951,10 @@ int gicv3_its_make_hwdom_dt_nodes(const struct domain *d,
>         if ( res )
>             return res;
> 
> +        res = fdt_property_cell(fdt, "#msi-cells", 1);
> +        if ( res )
> +            return res;
> +
>         if ( its->phandle )
>         {
>             res = fdt_property_cell(fdt, "phandle", its->phandle);
> 
> base-commit: 984cb316cb27b53704c607e640a7dd2763b898ab
> -- 
> 2.45.2
> 
> 

On Fri, 2 Aug 2024, Stewart Hildebrand wrote:
> Non-PCI platform devices may use the ITS. Dom0 Linux drivers for such
> devices are failing to register IRQs due to a missing #msi-cells
> property. Add the missing #msi-cells property.
> 
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> See Linux dc4dae00d82f ("Docs: dt: add #msi-cells to GICv3 ITS binding")
> ---
>  xen/arch/arm/gic-v3-its.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c
> index 8afcd9783bc8..55bed3fe87d0 100644
> --- a/xen/arch/arm/gic-v3-its.c
> +++ b/xen/arch/arm/gic-v3-its.c
> @@ -951,6 +951,10 @@ int gicv3_its_make_hwdom_dt_nodes(const struct domain *d,
>          if ( res )
>              return res;
>  
> +        res = fdt_property_cell(fdt, "#msi-cells", 1);
> +        if ( res )
> +            return res;
> +
>          if ( its->phandle )
>          {
>              res = fdt_property_cell(fdt, "phandle", its->phandle);
> 
> base-commit: 984cb316cb27b53704c607e640a7dd2763b898ab
> -- 
> 2.45.2
>

Hi,

On 02/08/2024 22:20, Stefano Stabellini wrote:
> On Fri, 2 Aug 2024, Stewart Hildebrand wrote:
>> Non-PCI platform devices may use the ITS. Dom0 Linux drivers for such
>> devices are failing to register IRQs due to a missing #msi-cells
>> property. Add the missing #msi-cells property.
>>
>> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

This is now committed.

Cheers,

-- 
Julien Grall