Appears to been missed from the previous attempt in 2007.

Fixes: fed194611785 ("xenstore: Remove broken and unmaintained test code")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Anthony PERARD <anthony@xenproject.org>
CC: Juergen Gross <jgross@suse.com>
---
 tools/libs/store/xs.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tools/libs/store/xs.c b/tools/libs/store/xs.c
index f84fd0f74c84..983d68ffd367 100644
--- a/tools/libs/store/xs.c
+++ b/tools/libs/store/xs.c
@@ -496,10 +496,6 @@ static bool read_all(int fd, void *data, unsigned int len, int nonblocking)
 	return false;
 }
 
-#ifdef XSTEST
-#define read_all read_all_choice
-#define xs_write_all write_all_choice
-#else
 /* Simple routine for writing to sockets, etc. */
 bool xs_write_all(int fd, const void *data, unsigned int len)
 {
@@ -517,7 +513,6 @@ bool xs_write_all(int fd, const void *data, unsigned int len)
 
 	return true;
 }
-#endif
 
 static int get_error(const char *errorstring)
 {
-- 
2.39.2

On 28.06.24 17:08, Andrew Cooper wrote:
> Appears to been missed from the previous attempt in 2007.
> 
> Fixes: fed194611785 ("xenstore: Remove broken and unmaintained test code")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen