tools/libxs: More CLOEXEC fixes

[PATCH for-4.19(?) 0/3] tools/libxs: More CLOEXEC fixes

Posted by Andrew Cooper 2 months, 1 week ago

More fixes to CLOEXEC handling in libxenstore.  For 4.19, because the first
attempt to fix this wasn't complete.

libxl is far worse, but I don't have time to get started on that mess.

Andrew Cooper (3):
  tools/libxs: Fix CLOEXEC handling in get_dev()
  tools/libxs: Fix CLOEXEC handling in get_socket()
  tools/libxs: Fix CLOEXEC handling in xs_fileno()

 tools/config.h.in     |  3 ++
 tools/configure       | 12 ++++++++
 tools/configure.ac    |  2 ++
 tools/libs/store/xs.c | 68 ++++++++++++++++++++++++++++++++++---------
 4 files changed, 72 insertions(+), 13 deletions(-)

-- 
2.39.2

Re: [PATCH for-4.19(?) 0/3] tools/libxs: More CLOEXEC fixes

Posted by Oleksii 2 months, 1 week ago

On Fri, 2024-06-28 at 15:31 +0100, Andrew Cooper wrote:
> More fixes to CLOEXEC handling in libxenstore.  For 4.19, because the
> first
> attempt to fix this wasn't complete.
> 
> libxl is far worse, but I don't have time to get started on that
> mess.
> 
> Andrew Cooper (3):
>   tools/libxs: Fix CLOEXEC handling in get_dev()
>   tools/libxs: Fix CLOEXEC handling in get_socket()
>   tools/libxs: Fix CLOEXEC handling in xs_fileno()
> 
>  tools/config.h.in     |  3 ++
>  tools/configure       | 12 ++++++++
>  tools/configure.ac    |  2 ++
>  tools/libs/store/xs.c | 68 ++++++++++++++++++++++++++++++++++-------
> --
>  4 files changed, 72 insertions(+), 13 deletions(-)
> 
For the whole series:
 Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

~ Oleksii

Re: [PATCH for-4.19(?) 0/3] tools/libxs: More CLOEXEC fixes

Posted by Jürgen Groß 2 months, 1 week ago

On 28.06.24 16:31, Andrew Cooper wrote:
> More fixes to CLOEXEC handling in libxenstore.  For 4.19, because the first
> attempt to fix this wasn't complete.
> 
> libxl is far worse, but I don't have time to get started on that mess.
> 
> Andrew Cooper (3):
>    tools/libxs: Fix CLOEXEC handling in get_dev()
>    tools/libxs: Fix CLOEXEC handling in get_socket()
>    tools/libxs: Fix CLOEXEC handling in xs_fileno()
> 
>   tools/config.h.in     |  3 ++
>   tools/configure       | 12 ++++++++
>   tools/configure.ac    |  2 ++
>   tools/libs/store/xs.c | 68 ++++++++++++++++++++++++++++++++++---------
>   4 files changed, 72 insertions(+), 13 deletions(-)
> 

For the series:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

Re: [PATCH for-4.19(?) 0/3] tools/libxs: More CLOEXEC fixes

Posted by Anthony PERARD 2 months, 1 week ago

On Mon, Jul 01, 2024 at 11:03:02AM +0200, Jürgen Groß wrote:
> On 28.06.24 16:31, Andrew Cooper wrote:
> > More fixes to CLOEXEC handling in libxenstore.  For 4.19, because the first
> > attempt to fix this wasn't complete.
> > 
> > libxl is far worse, but I don't have time to get started on that mess.
> > 
> > Andrew Cooper (3):
> >    tools/libxs: Fix CLOEXEC handling in get_dev()
> >    tools/libxs: Fix CLOEXEC handling in get_socket()
> >    tools/libxs: Fix CLOEXEC handling in xs_fileno()
> > 
> >   tools/config.h.in     |  3 ++
> >   tools/configure       | 12 ++++++++
> >   tools/configure.ac    |  2 ++
> >   tools/libs/store/xs.c | 68 ++++++++++++++++++++++++++++++++++---------
> >   4 files changed, 72 insertions(+), 13 deletions(-)
> > 
> 
> For the series:
> 
> Reviewed-by: Juergen Gross <jgross@suse.com>

Acked-by: Anthony PERARD <anthony.perard@vates.tech>

Thanks,

-- 

Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech