x86/cpufreq: clean up stale powernow_cpufreq_init()

[XEN PATCH] x86/cpufreq: clean up stale powernow_cpufreq_init()

Sergiy Kibrik posted 1 patch 5 months, 3 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20240604084629.2418430-1-Sergiy._5FKibrik@epam.com

xen/include/acpi/cpufreq/processor_perf.h | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[XEN PATCH] x86/cpufreq: clean up stale powernow_cpufreq_init()

Posted by Sergiy Kibrik 5 months, 3 weeks ago

Remove useless declaration. The routine itself was removed by following
commit long time ago:

   222013114 x86: Fix RevF detection in powernow.c

No functional change.

Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
---
 xen/include/acpi/cpufreq/processor_perf.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/include/acpi/cpufreq/processor_perf.h b/xen/include/acpi/cpufreq/processor_perf.h
index 5f48aceadb..301104e16f 100644
--- a/xen/include/acpi/cpufreq/processor_perf.h
+++ b/xen/include/acpi/cpufreq/processor_perf.h
@@ -7,7 +7,6 @@
 
 #define XEN_PX_INIT 0x80000000U
 
-int powernow_cpufreq_init(void);
 unsigned int powernow_register_driver(void);
 unsigned int get_measured_perf(unsigned int cpu, unsigned int flag);
 void cpufreq_residency_update(unsigned int cpu, uint8_t state);
-- 
2.25.1

Re: [XEN PATCH] x86/cpufreq: clean up stale powernow_cpufreq_init()

Posted by Jan Beulich 5 months, 3 weeks ago

On 04.06.2024 10:46, Sergiy Kibrik wrote:
> Remove useless declaration. The routine itself was removed by following
> commit long time ago:
> 
>    222013114 x86: Fix RevF detection in powernow.c
> 
> No functional change.
> 
> Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

This actually addresses a Misra rule 8.6 violation, afaict. Would
be good to mention in the description (happy to add a sentence
when [eventually] committing).

Jan