1. Patchew
  2. Xen
  3. [PATCH for-4.19 0/3] CI: Misc improvements
  4. View patch

[PATCH 2/3] CI: Use a debug build of Xen for the Xilinx HW tests

Andrew Cooper posted 3 patches 5 months, 4 weeks ago
[PATCH 2/3] CI: Use a debug build of Xen for the Xilinx HW tests
Posted by Andrew Cooper 5 months, 4 weeks ago 
... like the other hardware tests.  This gets more value out of the testing.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Michal Orzel <michal.orzel@amd.com>
CC: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
CC: Oleksii Kurochko <oleksii.kurochko@gmail.com>
---
 automation/gitlab-ci/test.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
index efd3ad46f08e..e96ccdfad54c 100644
--- a/automation/gitlab-ci/test.yaml
+++ b/automation/gitlab-ci/test.yaml
@@ -149,7 +149,7 @@ xilinx-smoke-dom0less-arm64-gcc:
     - ./automation/scripts/xilinx-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE}
   needs:
     - *arm64-test-needs
-    - alpine-3.18-gcc-arm64
+    - alpine-3.18-gcc-debug-arm64
 
 xilinx-smoke-dom0less-arm64-gcc-gem-passthrough:
   extends: .xilinx-arm64
@@ -157,7 +157,7 @@ xilinx-smoke-dom0less-arm64-gcc-gem-passthrough:
     - ./automation/scripts/xilinx-smoke-dom0less-arm64.sh gem-passthrough 2>&1 | tee ${LOGFILE}
   needs:
     - *arm64-test-needs
-    - alpine-3.18-gcc-arm64
+    - alpine-3.18-gcc-debug-arm64
 
 adl-smoke-x86-64-gcc-debug:
   extends: .adl-x86-64
-- 
2.30.2
Re: [PATCH 2/3] CI: Use a debug build of Xen for the Xilinx HW tests
Posted by Stefano Stabellini 5 months, 3 weeks ago 
On Wed, 29 May 2024, Andrew Cooper wrote:
> ... like the other hardware tests.  This gets more value out of the testing.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>

> ---
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Michal Orzel <michal.orzel@amd.com>
> CC: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> CC: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> ---
>  automation/gitlab-ci/test.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
> index efd3ad46f08e..e96ccdfad54c 100644
> --- a/automation/gitlab-ci/test.yaml
> +++ b/automation/gitlab-ci/test.yaml
> @@ -149,7 +149,7 @@ xilinx-smoke-dom0less-arm64-gcc:
>      - ./automation/scripts/xilinx-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE}
>    needs:
>      - *arm64-test-needs
> -    - alpine-3.18-gcc-arm64
> +    - alpine-3.18-gcc-debug-arm64
>  
>  xilinx-smoke-dom0less-arm64-gcc-gem-passthrough:
>    extends: .xilinx-arm64
> @@ -157,7 +157,7 @@ xilinx-smoke-dom0less-arm64-gcc-gem-passthrough:
>      - ./automation/scripts/xilinx-smoke-dom0less-arm64.sh gem-passthrough 2>&1 | tee ${LOGFILE}
>    needs:
>      - *arm64-test-needs
> -    - alpine-3.18-gcc-arm64
> +    - alpine-3.18-gcc-debug-arm64
>  
>  adl-smoke-x86-64-gcc-debug:
>    extends: .adl-x86-64
> -- 
> 2.30.2
>
Re: [PATCH 2/3] CI: Use a debug build of Xen for the Xilinx HW tests
Posted by Michal Orzel 5 months, 4 weeks ago 
Hi Andrew,

On 29/05/2024 16:19, Andrew Cooper wrote:
> 
> 
> ... like the other hardware tests.  This gets more value out of the testing.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Michal Orzel <michal.orzel@amd.com>
> CC: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> CC: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> ---
>  automation/gitlab-ci/test.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
> index efd3ad46f08e..e96ccdfad54c 100644
> --- a/automation/gitlab-ci/test.yaml
> +++ b/automation/gitlab-ci/test.yaml
> @@ -149,7 +149,7 @@ xilinx-smoke-dom0less-arm64-gcc:
>      - ./automation/scripts/xilinx-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE}
>    needs:
>      - *arm64-test-needs
> -    - alpine-3.18-gcc-arm64
> +    - alpine-3.18-gcc-debug-arm64
This change should be reflected in the name of the test changed (here and below), so that it contains -debug suffix just like every other debug job.
With that done:
Reviewed-by: Michal Orzel <michal.orzel@amd.com>

~Michal
Re: [PATCH 2/3] CI: Use a debug build of Xen for the Xilinx HW tests
Posted by Stefano Stabellini 5 months, 3 weeks ago 
On Wed, 29 May 2024, Michal Orzel wrote:
> Hi Andrew,
> 
> On 29/05/2024 16:19, Andrew Cooper wrote:
> > 
> > 
> > ... like the other hardware tests.  This gets more value out of the testing.
> > 
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > ---
> > CC: Roger Pau Monné <roger.pau@citrix.com>
> > CC: Stefano Stabellini <sstabellini@kernel.org>
> > CC: Michal Orzel <michal.orzel@amd.com>
> > CC: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> > CC: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> > ---
> >  automation/gitlab-ci/test.yaml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
> > index efd3ad46f08e..e96ccdfad54c 100644
> > --- a/automation/gitlab-ci/test.yaml
> > +++ b/automation/gitlab-ci/test.yaml
> > @@ -149,7 +149,7 @@ xilinx-smoke-dom0less-arm64-gcc:
> >      - ./automation/scripts/xilinx-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE}
> >    needs:
> >      - *arm64-test-needs
> > -    - alpine-3.18-gcc-arm64
> > +    - alpine-3.18-gcc-debug-arm64
> This change should be reflected in the name of the test changed (here and below), so that it contains -debug suffix just like every other debug job.
> With that done:
> Reviewed-by: Michal Orzel <michal.orzel@amd.com>

Ops, good catch! I missed it
Re: [PATCH 2/3] CI: Use a debug build of Xen for the Xilinx HW tests
Posted by Andrew Cooper 5 months, 4 weeks ago 
On 29/05/2024 4:30 pm, Michal Orzel wrote:
> Hi Andrew,
>
> On 29/05/2024 16:19, Andrew Cooper wrote:
>>
>> ... like the other hardware tests.  This gets more value out of the testing.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Roger Pau Monné <roger.pau@citrix.com>
>> CC: Stefano Stabellini <sstabellini@kernel.org>
>> CC: Michal Orzel <michal.orzel@amd.com>
>> CC: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
>> CC: Oleksii Kurochko <oleksii.kurochko@gmail.com>
>> ---
>>  automation/gitlab-ci/test.yaml | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
>> index efd3ad46f08e..e96ccdfad54c 100644
>> --- a/automation/gitlab-ci/test.yaml
>> +++ b/automation/gitlab-ci/test.yaml
>> @@ -149,7 +149,7 @@ xilinx-smoke-dom0less-arm64-gcc:
>>      - ./automation/scripts/xilinx-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE}
>>    needs:
>>      - *arm64-test-needs
>> -    - alpine-3.18-gcc-arm64
>> +    - alpine-3.18-gcc-debug-arm64
> This change should be reflected in the name of the test changed (here and below), so that it contains -debug suffix just like every other debug job.
> With that done:
> Reviewed-by: Michal Orzel <michal.orzel@amd.com>

Wow, this is a giant mess.  There's no consistency anywhere.

I've got a debug suffix for this one, and a debug infix for the other
one, but I'm seriously tempted to sed over the whole config and clean
this up for once and for all.

~Andrew

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.