xen-livepatch: fix --force option comparison

[PATCH] xen-livepatch: fix --force option comparison

Roger Pau Monne posted 1 patch 1 week, 3 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20240426072144.48828-1-roger.pau@citrix.com

tools/misc/xen-livepatch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] xen-livepatch: fix --force option comparison

Posted by Roger Pau Monne 1 week, 3 days ago

The check for --force option shouldn't be against 0.

Reported-by: Jan Beulich <jbeulich@suse.com>
Fixes: 62a72092a517 ('livepatch: introduce --force option')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 tools/misc/xen-livepatch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/misc/xen-livepatch.c b/tools/misc/xen-livepatch.c
index c16fb6862d6c..f406ea1373ae 100644
--- a/tools/misc/xen-livepatch.c
+++ b/tools/misc/xen-livepatch.c
@@ -576,7 +576,7 @@ int main(int argc, char *argv[])
         return 0;
     }
 
-    if ( strcmp("--force", argv[1]) )
+    if ( !strcmp("--force", argv[1]) )
     {
         if ( argc <= 2 )
         {
-- 
2.44.0

Re: [PATCH] xen-livepatch: fix --force option comparison

Posted by Ross Lagerwall 1 week, 3 days ago

On Fri, Apr 26, 2024 at 8:21 AM Roger Pau Monne <roger.pau@citrix.com> wrote:
>
> The check for --force option shouldn't be against 0.
>
> Reported-by: Jan Beulich <jbeulich@suse.com>
> Fixes: 62a72092a517 ('livepatch: introduce --force option')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---

Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>

Re: [PATCH] xen-livepatch: fix --force option comparison

Posted by Anthony PERARD 1 week, 3 days ago

On Fri, Apr 26, 2024 at 09:21:44AM +0200, Roger Pau Monne wrote:
> The check for --force option shouldn't be against 0.
> 
> Reported-by: Jan Beulich <jbeulich@suse.com>
> Fixes: 62a72092a517 ('livepatch: introduce --force option')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD