xen/xlat: Improvements to compat hypercall checking

[PATCH 0/4] xen/xlat: Improvements to compat hypercall checking

Andrew Cooper posted 4 patches 1 year, 9 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20240415154155.2718064-1-andrew.cooper3@citrix.com

xen/common/Makefile              |  1 +
xen/common/compat/grant_table.c  |  4 ++
xen/common/hdr-chk.c             | 13 ++++++
xen/include/public/grant_table.h |  7 ++++
xen/include/xlat.lst             | 70 +++++++++++++++++++++-----------
5 files changed, 72 insertions(+), 23 deletions(-)
create mode 100644 xen/common/hdr-chk.c

Expand all Fold all

[PATCH 0/4] xen/xlat: Improvements to compat hypercall checking

Posted by Andrew Cooper 1 year, 9 months ago

This started off as patch 3, and grew somewhat.

Patches 1-3 are simple and hopefully non-controversial.

Patch 4 is an attempt to make the headers less fragile, but came with an
unexpected complication.  Details in the patch.

Andrew Cooper (4):
  xen/xlat: Sort out whitespace
  xen/xlat: Sort structs per file
  xen/gnttab: Perform compat/native gnttab_query_size check
  xen/public: Use -Wpadding for public headers

 xen/common/Makefile              |  1 +
 xen/common/compat/grant_table.c  |  4 ++
 xen/common/hdr-chk.c             | 13 ++++++
 xen/include/public/grant_table.h |  7 ++++
 xen/include/xlat.lst             | 70 +++++++++++++++++++++-----------
 5 files changed, 72 insertions(+), 23 deletions(-)
 create mode 100644 xen/common/hdr-chk.c


base-commit: c0f890cd9d5fd2c17a1e3110cb26f98c90ce8429
-- 
2.30.2

Re: [PATCH for-4.19 0/4] xen/xlat: Improvements to compat hypercall checking

Posted by Andrew Cooper 1 year, 7 months ago

On 15/04/2024 4:41 pm, Andrew Cooper wrote:
> This started off as patch 3, and grew somewhat.
>
> Patches 1-3 are simple and hopefully non-controversial.
>
> Patch 4 is an attempt to make the headers less fragile, but came with an
> unexpected complication.  Details in the patch.
>
> Andrew Cooper (4):
>   xen/xlat: Sort out whitespace
>   xen/xlat: Sort structs per file
>   xen/gnttab: Perform compat/native gnttab_query_size check

I'm timing out waiting for a justification on the whitespace comment.

Oleksii: Can I get a release ack on this please?  Patch 3 is the main
bugfix, which is the insertion of a missing build-time cross-check, so
it's very low risk for the release.

Patch 4 was always RFC and not intended to go in as-was.

~Andrew

Re: [PATCH for-4.19 0/4] xen/xlat: Improvements to compat hypercall checking

Posted by Oleksii 1 year, 7 months ago

On Fri, 2024-06-21 at 17:34 +0100, Andrew Cooper wrote:
> On 15/04/2024 4:41 pm, Andrew Cooper wrote:
> > This started off as patch 3, and grew somewhat.
> > 
> > Patches 1-3 are simple and hopefully non-controversial.
> > 
> > Patch 4 is an attempt to make the headers less fragile, but came
> > with an
> > unexpected complication.  Details in the patch.
> > 
> > Andrew Cooper (4):
> >   xen/xlat: Sort out whitespace
> >   xen/xlat: Sort structs per file
> >   xen/gnttab: Perform compat/native gnttab_query_size check
> 
> I'm timing out waiting for a justification on the whitespace comment.
> 
> Oleksii: Can I get a release ack on this please?  Patch 3 is the main
> bugfix, which is the insertion of a missing build-time cross-check,
> so
> it's very low risk for the release.
Release-Acked-By: Oleksii Kurochko <oleksii.kurochko@gmail.com>

~ Oleksii

> 
> Patch 4 was always RFC and not intended to go in as-was.
> 
> ~Andrew