x86/emul: Adjust X86EMUL_OPC_EXT_MASK to placate MISRA

[PATCH] x86/emul: Adjust X86EMUL_OPC_EXT_MASK to placate MISRA

Posted by Andrew Cooper 3 weeks, 2 days ago

Resolves 4740 MISRA R7.2 violations.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: consulting@bugseng.com <consulting@bugseng.com>
CC: Roberto Bagnara <roberto.bagnara@bugseng.com>
CC: Federico Serafini <federico.serafini@bugseng.com>
CC: Nicola Vetrini <nicola.vetrini@bugseng.com>

of 4935, so 96% of them...
---
 xen/arch/x86/x86_emulate/x86_emulate.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h b/xen/arch/x86/x86_emulate/x86_emulate.h
index 698750267a90..d92be69d84d9 100644
--- a/xen/arch/x86/x86_emulate/x86_emulate.h
+++ b/xen/arch/x86/x86_emulate/x86_emulate.h
@@ -620,7 +620,7 @@ struct x86_emulate_ctxt
  * below).
  * Hence no separate #define-s get added.
  */
-#define X86EMUL_OPC_EXT_MASK         0xffff0000
+#define X86EMUL_OPC_EXT_MASK         0xffff0000U
 #define X86EMUL_OPC(ext, byte)       ((uint8_t)(byte) | \
                                       MASK_INSR((ext), X86EMUL_OPC_EXT_MASK))
 /*

base-commit: 0e7ea8ca5fc9bce9248414f6aaf2dc861abd45d9
prerequisite-patch-id: 8d06e56c5d8a52f1387e1f5a7fce6a94b8c4a1ed
prerequisite-patch-id: 13355d26254b979c79de456c9a6ea6a9c639ba63
prerequisite-patch-id: d1f308616490257685a49248e29f1b3516c2dde4
-- 
2.30.2

Re: [PATCH] x86/emul: Adjust X86EMUL_OPC_EXT_MASK to placate MISRA

Posted by Stefano Stabellini 3 weeks, 1 day ago

On Wed, 10 Apr 2024, Andrew Cooper wrote:
> Resolves 4740 MISRA R7.2 violations.

LOL!!


> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>


Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: consulting@bugseng.com <consulting@bugseng.com>
> CC: Roberto Bagnara <roberto.bagnara@bugseng.com>
> CC: Federico Serafini <federico.serafini@bugseng.com>
> CC: Nicola Vetrini <nicola.vetrini@bugseng.com>
> 
> of 4935, so 96% of them...
> ---
>  xen/arch/x86/x86_emulate/x86_emulate.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h b/xen/arch/x86/x86_emulate/x86_emulate.h
> index 698750267a90..d92be69d84d9 100644
> --- a/xen/arch/x86/x86_emulate/x86_emulate.h
> +++ b/xen/arch/x86/x86_emulate/x86_emulate.h
> @@ -620,7 +620,7 @@ struct x86_emulate_ctxt
>   * below).
>   * Hence no separate #define-s get added.
>   */
> -#define X86EMUL_OPC_EXT_MASK         0xffff0000
> +#define X86EMUL_OPC_EXT_MASK         0xffff0000U
>  #define X86EMUL_OPC(ext, byte)       ((uint8_t)(byte) | \
>                                        MASK_INSR((ext), X86EMUL_OPC_EXT_MASK))
>  /*
> 
> base-commit: 0e7ea8ca5fc9bce9248414f6aaf2dc861abd45d9
> prerequisite-patch-id: 8d06e56c5d8a52f1387e1f5a7fce6a94b8c4a1ed
> prerequisite-patch-id: 13355d26254b979c79de456c9a6ea6a9c639ba63
> prerequisite-patch-id: d1f308616490257685a49248e29f1b3516c2dde4
> -- 
> 2.30.2
>