[v1] drivers: char: Enable OMAP UART driver for TI K3 devices

[PATCH] drivers: char: Enable OMAP UART driver for TI K3 devices

Posted by Vaishnav Achath 7 months, 2 weeks ago

TI K3 devices (J721E, J721S2, AM62X .etc) has the same variant
of UART as OMAP4. Add the compatible used in Linux device tree,
"ti,am654-uart" to the omap-uart dt_match so that the driver can
be used with these devices. Also enable the driver for ARM64
platforms.

Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
---

Xen logs from J721E EVM: https://gist.github.com/vaishnavachath/8185e2378981705e1deb121f109f46b5

 xen/drivers/char/Kconfig     | 2 +-
 xen/drivers/char/omap-uart.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
index e18ec3788c..dcb9e85853 100644
--- a/xen/drivers/char/Kconfig
+++ b/xen/drivers/char/Kconfig
@@ -55,7 +55,7 @@ config HAS_EXYNOS4210
 config HAS_OMAP
 	bool "Texas Instruments OMAP UART driver"
 	default y
-	depends on ARM_32
+	depends on ARM_32 || ARM_64
 	help
 	  This selects the Texas Instruments OMAP UART. If you have a Texas
 	  Instruments based CPU, say Y.
diff --git a/xen/drivers/char/omap-uart.c b/xen/drivers/char/omap-uart.c
index f4368c158c..03b5b66e7a 100644
--- a/xen/drivers/char/omap-uart.c
+++ b/xen/drivers/char/omap-uart.c
@@ -372,6 +372,7 @@ static int __init omap_uart_init(struct dt_device_node *dev,
 static const struct dt_device_match omap_uart_dt_match[] __initconst =
 {
     DT_MATCH_COMPATIBLE("ti,omap4-uart"),
+    DT_MATCH_COMPATIBLE("ti,am654-uart"),
     { /* sentinel */ },
 };
 
-- 
2.34.1

Re: [PATCH] drivers: char: Enable OMAP UART driver for TI K3 devices

Posted by Michal Orzel 7 months, 2 weeks ago

Hi,

On 08/04/2024 14:11, Vaishnav Achath wrote:
> 
> 
> TI K3 devices (J721E, J721S2, AM62X .etc) has the same variant
s/has/have

> of UART as OMAP4. Add the compatible used in Linux device tree,
> "ti,am654-uart" to the omap-uart dt_match so that the driver can
> be used with these devices. Also enable the driver for ARM64
> platforms.
> 
> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> ---
> 
> Xen logs from J721E EVM: https://gist.github.com/vaishnavachath/8185e2378981705e1deb121f109f46b5
> 
>  xen/drivers/char/Kconfig     | 2 +-
>  xen/drivers/char/omap-uart.c | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
> index e18ec3788c..dcb9e85853 100644
> --- a/xen/drivers/char/Kconfig
> +++ b/xen/drivers/char/Kconfig
> @@ -55,7 +55,7 @@ config HAS_EXYNOS4210
>  config HAS_OMAP
>         bool "Texas Instruments OMAP UART driver"
>         default y
> -       depends on ARM_32
> +       depends on ARM_32 || ARM_64
depends on ARM please

With that:
Reviewed-by: Michal Orzel <michal.orzel@amd.com>

~Michal