[PATCH 0/7] xen/trace: Treewide API cleanup

Andrew Cooper posted 7 patches 1 month, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20240318163552.3808695-1-andrew.cooper3@citrix.com
xen/arch/x86/acpi/cpu_idle.c           |  12 +-
xen/arch/x86/compat.c                  |   4 +-
xen/arch/x86/cpu/mwait-idle.c          |   6 +-
xen/arch/x86/emul-i8254.c              |  14 +-
xen/arch/x86/hvm/emulate.c             |  11 +-
xen/arch/x86/hvm/hpet.c                |   7 +-
xen/arch/x86/hvm/hvm.c                 |  20 +-
xen/arch/x86/hvm/io.c                  |   1 -
xen/arch/x86/hvm/rtc.c                 |  12 +-
xen/arch/x86/hvm/svm/intr.c            |   7 +-
xen/arch/x86/hvm/svm/svm.c             |  43 ++--
xen/arch/x86/hvm/vlapic.c              |  52 +++--
xen/arch/x86/hvm/vmx/intr.c            |   7 +-
xen/arch/x86/hvm/vmx/vmx.c             |  57 +++--
xen/arch/x86/hvm/vpic.c                |  13 +-
xen/arch/x86/include/asm/hvm/trace.h   | 114 ----------
xen/arch/x86/include/asm/hvm/vmx/vmx.h |   1 -
xen/arch/x86/irq.c                     |  16 +-
xen/arch/x86/mm/p2m-pod.c              |   8 +-
xen/arch/x86/mm/p2m-pt.c               |   2 +-
xen/arch/x86/mm/shadow/common.c        |   6 +-
xen/arch/x86/mm/shadow/multi.c         |  10 +-
xen/arch/x86/pv/trace.c                |  21 +-
xen/arch/x86/traps.c                   |   2 +-
xen/common/domain.c                    |   4 +-
xen/common/grant_table.c               |   6 +-
xen/common/memory.c                    |   2 +-
xen/common/sched/core.c                |  56 +++--
xen/common/sched/credit.c              |  70 +++---
xen/common/sched/credit2.c             | 301 ++++++++++++-------------
xen/common/sched/null.c                |  63 +++---
xen/common/sched/rt.c                  |  99 ++++----
xen/common/trace.c                     |   9 +-
xen/drivers/cpufreq/utility.c          |   2 +-
xen/include/xen/trace.h                |  67 ++----
35 files changed, 493 insertions(+), 632 deletions(-)
delete mode 100644 xen/arch/x86/include/asm/hvm/trace.h
[PATCH 0/7] xen/trace: Treewide API cleanup
Posted by Andrew Cooper 1 month, 1 week ago
Rework the trace API to unify it (remove the HVM specific obfuscation), and
remove MISRA violations.

v3:
 * Delete TRACE_PARAM64()

Andrew Cooper (7):
  xen/trace: Introduce new API
  xen/credit2: Clean up trace handling
  xen/rt: Clean up trace handling
  xen/sched: Clean up trace handling
  xen: Switch to new TRACE() API
  xen/trace: Update final {__,}trace_var() users to the new API
  xen/trace: Drop old trace API

 xen/arch/x86/acpi/cpu_idle.c           |  12 +-
 xen/arch/x86/compat.c                  |   4 +-
 xen/arch/x86/cpu/mwait-idle.c          |   6 +-
 xen/arch/x86/emul-i8254.c              |  14 +-
 xen/arch/x86/hvm/emulate.c             |  11 +-
 xen/arch/x86/hvm/hpet.c                |   7 +-
 xen/arch/x86/hvm/hvm.c                 |  20 +-
 xen/arch/x86/hvm/io.c                  |   1 -
 xen/arch/x86/hvm/rtc.c                 |  12 +-
 xen/arch/x86/hvm/svm/intr.c            |   7 +-
 xen/arch/x86/hvm/svm/svm.c             |  43 ++--
 xen/arch/x86/hvm/vlapic.c              |  52 +++--
 xen/arch/x86/hvm/vmx/intr.c            |   7 +-
 xen/arch/x86/hvm/vmx/vmx.c             |  57 +++--
 xen/arch/x86/hvm/vpic.c                |  13 +-
 xen/arch/x86/include/asm/hvm/trace.h   | 114 ----------
 xen/arch/x86/include/asm/hvm/vmx/vmx.h |   1 -
 xen/arch/x86/irq.c                     |  16 +-
 xen/arch/x86/mm/p2m-pod.c              |   8 +-
 xen/arch/x86/mm/p2m-pt.c               |   2 +-
 xen/arch/x86/mm/shadow/common.c        |   6 +-
 xen/arch/x86/mm/shadow/multi.c         |  10 +-
 xen/arch/x86/pv/trace.c                |  21 +-
 xen/arch/x86/traps.c                   |   2 +-
 xen/common/domain.c                    |   4 +-
 xen/common/grant_table.c               |   6 +-
 xen/common/memory.c                    |   2 +-
 xen/common/sched/core.c                |  56 +++--
 xen/common/sched/credit.c              |  70 +++---
 xen/common/sched/credit2.c             | 301 ++++++++++++-------------
 xen/common/sched/null.c                |  63 +++---
 xen/common/sched/rt.c                  |  99 ++++----
 xen/common/trace.c                     |   9 +-
 xen/drivers/cpufreq/utility.c          |   2 +-
 xen/include/xen/trace.h                |  67 ++----
 35 files changed, 493 insertions(+), 632 deletions(-)
 delete mode 100644 xen/arch/x86/include/asm/hvm/trace.h


base-commit: 62018f08708a5ff6ef8fc8ff2aaaac46e5a60430
-- 
2.30.2
Re: [PATCH 0/7] xen/trace: Treewide API cleanup
Posted by Nicola Vetrini 1 month, 1 week ago
On 2024-03-18 17:35, Andrew Cooper wrote:
> Rework the trace API to unify it (remove the HVM specific obfuscation), 
> and
> remove MISRA violations.
> 
> v3:
>  * Delete TRACE_PARAM64()
> 
> Andrew Cooper (7):
>   xen/trace: Introduce new API
>   xen/credit2: Clean up trace handling
>   xen/rt: Clean up trace handling
>   xen/sched: Clean up trace handling
>   xen: Switch to new TRACE() API
>   xen/trace: Update final {__,}trace_var() users to the new API
>   xen/trace: Drop old trace API

Hi Andrew,

thanks for the series. I'll run it trough ECLAIR when I have some spare 
time, so that we can assess the impact especially on Rule 20.7.

-- 
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
Re: [PATCH 0/7] xen/trace: Treewide API cleanup
Posted by Nicola Vetrini 1 month, 1 week ago
On 2024-03-20 12:01, Nicola Vetrini wrote:
> On 2024-03-18 17:35, Andrew Cooper wrote:
>> Rework the trace API to unify it (remove the HVM specific 
>> obfuscation), and
>> remove MISRA violations.
>> 
>> v3:
>>  * Delete TRACE_PARAM64()
>> 
>> Andrew Cooper (7):
>>   xen/trace: Introduce new API
>>   xen/credit2: Clean up trace handling
>>   xen/rt: Clean up trace handling
>>   xen/sched: Clean up trace handling
>>   xen: Switch to new TRACE() API
>>   xen/trace: Update final {__,}trace_var() users to the new API
>>   xen/trace: Drop old trace API
> 
> Hi Andrew,
> 
> thanks for the series. I'll run it trough ECLAIR when I have some spare 
> time, so that we can assess the impact especially on Rule 20.7.

Everything is fine for Rule 20.7 in a differential run with respect to 
yesterday's staging branch

-- 
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)