SUPPORT.MD: Fix matrix generation after 43c416d0d819 and 77c39a53cf5b

[PATCH] SUPPORT.MD: Fix matrix generation after 43c416d0d819 and 77c39a53cf5b

Posted by Julien Grall 1 year, 11 months ago

From: Julien Grall <jgrall@amazon.com>

The script docs/support-matrix-generate throw the following error on the
latest staging.

MDCCSR_EL0
DBGDTR_EL0
DBGDTRTX_EL0
DBGDTRRX_EL0
DBGDSCRINT
DBGDTRTXINT
DBGDTRRXINT
^ cannot parse status codeblock line:
MDCCSR_EL0
 ? at docs/parse-support-md line 172, <F> chunk 1.

With the current indentation, it looks like the script thinks this is
a status code block.

Solve the issue by switching to a bullet list.

Fixes: 43c416d0d819 ("xen/arm: arm64: Add emulation of Debug Data Transfer Registers")
Fixes: 77c39a53cf5b ("xen/arm: arm32: Add emulation of Debug Data Transfer Registers")
---
 SUPPORT.md | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/SUPPORT.md b/SUPPORT.md
index 58f075538f73..e10d46d924a4 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -111,13 +111,13 @@ that would normally trigger a fault injection.
 
 Only the following system registers are security supported:
 
-    MDCCSR_EL0
-    DBGDTR_EL0
-    DBGDTRTX_EL0
-    DBGDTRRX_EL0
-    DBGDSCRINT
-    DBGDTRTXINT
-    DBGDTRRXINT
+  * MDCCSR_EL0
+  * DBGDTR_EL0
+  * DBGDTRTX_EL0
+  * DBGDTRRX_EL0
+  * DBGDSCRINT
+  * DBGDTRTXINT
+  * DBGDTRRXINT
 
 ### ARM Scalable Vector Extension (SVE/SVE2)
 
-- 
2.40.1

Re: [PATCH] SUPPORT.MD: Fix matrix generation after 43c416d0d819 and 77c39a53cf5b

Posted by George Dunlap 1 year, 11 months ago

On Thu, Mar 14, 2024 at 5:39 PM Julien Grall <julien@xen.org> wrote:
>
> From: Julien Grall <jgrall@amazon.com>
>
> The script docs/support-matrix-generate throw the following error on the
> latest staging.

I wonder if it would be worth adding a follow-up patch to run that
script, maybe only when debug=y, so it catches errors in development.

 -George

Re: [PATCH] SUPPORT.MD: Fix matrix generation after 43c416d0d819 and 77c39a53cf5b

Posted by Andrew Cooper 1 year, 11 months ago

On 15/03/2024 10:05 am, George Dunlap wrote:
> On Thu, Mar 14, 2024 at 5:39 PM Julien Grall <julien@xen.org> wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> The script docs/support-matrix-generate throw the following error on the
>> latest staging.
> I wonder if it would be worth adding a follow-up patch to run that
> script, maybe only when debug=y, so it catches errors in development.

I have a second docs thing which needs doing in some copious free
never.  The Sphinx build is getting broken occasionally and I'm the only
one who notices.

I was intending to have a Gitlab run specifically for docs, although the
container for it is going to need to be giant to get all of our ad-hoc
dependencies.

~Andrew

Re: [PATCH] SUPPORT.MD: Fix matrix generation after 43c416d0d819 and 77c39a53cf5b

Posted by Andrew Cooper 1 year, 11 months ago

On 14/03/2024 5:39 pm, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> The script docs/support-matrix-generate throw the following error on the
> latest staging.
>
> MDCCSR_EL0
> DBGDTR_EL0
> DBGDTRTX_EL0
> DBGDTRRX_EL0
> DBGDSCRINT
> DBGDTRTXINT
> DBGDTRRXINT
> ^ cannot parse status codeblock line:
> MDCCSR_EL0
>  ? at docs/parse-support-md line 172, <F> chunk 1.
>
> With the current indentation, it looks like the script thinks this is
> a status code block.
>
> Solve the issue by switching to a bullet list.
>
> Fixes: 43c416d0d819 ("xen/arm: arm64: Add emulation of Debug Data Transfer Registers")
> Fixes: 77c39a53cf5b ("xen/arm: arm32: Add emulation of Debug Data Transfer Registers")
> ---

You need a SoB somewhere, but Acked-by: Andrew Cooper
<andrew.cooper3@citrix.com>

Re: [PATCH] SUPPORT.MD: Fix matrix generation after 43c416d0d819 and 77c39a53cf5b

Posted by Julien Grall 1 year, 11 months ago


On 14/03/2024 17:41, Andrew Cooper wrote:
> On 14/03/2024 5:39 pm, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> The script docs/support-matrix-generate throw the following error on the
>> latest staging.
>>
>> MDCCSR_EL0
>> DBGDTR_EL0
>> DBGDTRTX_EL0
>> DBGDTRRX_EL0
>> DBGDSCRINT
>> DBGDTRTXINT
>> DBGDTRRXINT
>> ^ cannot parse status codeblock line:
>> MDCCSR_EL0
>>   ? at docs/parse-support-md line 172, <F> chunk 1.
>>
>> With the current indentation, it looks like the script thinks this is
>> a status code block.
>>
>> Solve the issue by switching to a bullet list.
>>
>> Fixes: 43c416d0d819 ("xen/arm: arm64: Add emulation of Debug Data Transfer Registers")
>> Fixes: 77c39a53cf5b ("xen/arm: arm32: Add emulation of Debug Data Transfer Registers")
>> ---
> 
> You need a SoB somewhere, but Acked-by: Andrew Cooper
> <andrew.cooper3@citrix.com>

Whoops yes:

Signed-off-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall