[PATCH 1/3] x86: i387.c cleanup

Fouad Hilly posted 3 patches 1 year, 11 months ago
[PATCH 1/3] x86: i387.c cleanup
Posted by Fouad Hilly 1 year, 11 months ago
From: Wei Liu <wei.liu2@citrix.com>

No functional change

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: Fouad Hilly <fouad.hilly@cloud.com>
---
CC: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: "Roger Pau Monné" <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/i387.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/i387.c b/xen/arch/x86/i387.c
index d824f2bb5294..7a4297cc921e 100644
--- a/xen/arch/x86/i387.c
+++ b/xen/arch/x86/i387.c
@@ -26,7 +26,7 @@ static inline void fpu_xrstor(struct vcpu *v, uint64_t mask)
 
     ASSERT(v->arch.xsave_area);
     /*
-     * XCR0 normally represents what guest OS set. In case of Xen itself, 
+     * XCR0 normally represents what guest OS set. In case of Xen itself,
      * we set the accumulated feature mask before doing save/restore.
      */
     ok = set_xcr0(v->arch.xcr0_accum | XSTATE_FP_SSE);
@@ -36,7 +36,7 @@ static inline void fpu_xrstor(struct vcpu *v, uint64_t mask)
     ASSERT(ok);
 }
 
-/* Restor x87 FPU, MMX, SSE and SSE2 state */
+/* Restore x87 FPU, MMX, SSE and SSE2 state */
 static inline void fpu_fxrstor(struct vcpu *v)
 {
     const typeof(v->arch.xsave_area->fpu_sse) *fpu_ctxt = v->arch.fpu_ctxt;
@@ -307,7 +307,7 @@ void save_fpu_enable(void)
 int vcpu_init_fpu(struct vcpu *v)
 {
     int rc;
-    
+
     v->arch.fully_eager_fpu = opt_eager_fpu;
 
     if ( (rc = xstate_alloc_save_area(v)) != 0 )
-- 
2.42.0


Re: [PATCH 1/3] x86: i387.c cleanup
Posted by Jan Beulich 1 year, 11 months ago
On 04.03.2024 10:13, Fouad Hilly wrote:
> From: Wei Liu <wei.liu2@citrix.com>
> 
> No functional change

I don't think that's what's relevant to mention here. Saying that it's
trailing blanks and spelling which are taken care of would have clarified
what's to expect before even looking at the changes. I may decide to take
the liberty of adding a sentence to this effect while committing ...

> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Signed-off-by: Fouad Hilly <fouad.hilly@cloud.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

Jan