Mini-OS: add symbol exports for xenstore stubdom

[PATCH] Mini-OS: add symbol exports for xenstore stubdom

Posted by Juergen Gross 2 months ago

Xenstore stubdom needs some more symbols exported.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xenbus.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xenbus.c b/xenbus.c
index eb9af055..686428a4 100644
--- a/xenbus.c
+++ b/xenbus.c
@@ -45,6 +45,7 @@
 #endif
 
 struct xenstore_domain_interface *xenstore_buf;
+EXPORT_SYMBOL(xenstore_buf);
 static DECLARE_WAIT_QUEUE_HEAD(xb_waitq);
 DECLARE_WAIT_QUEUE_HEAD(xenbus_watch_queue);
 static __DECLARE_SEMAPHORE_GENERIC(xb_write_sem, 1);
@@ -70,6 +71,7 @@ static struct xenbus_req_info req_info[NR_REQS];
 static char *errmsg(struct xsd_sockmsg *rep);
 
 uint32_t xenbus_evtchn;
+EXPORT_SYMBOL(xenbus_evtchn);
 
 #ifdef CONFIG_PARAVIRT
 void get_xenbus(void *p)
-- 
2.35.3

Re: [PATCH] Mini-OS: add symbol exports for xenstore stubdom

Posted by Samuel Thibault 1 month, 4 weeks ago

Juergen Gross, le lun. 26 févr. 2024 09:39:55 +0100, a ecrit:
> Xenstore stubdom needs some more symbols exported.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Thanks!

> ---
>  xenbus.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/xenbus.c b/xenbus.c
> index eb9af055..686428a4 100644
> --- a/xenbus.c
> +++ b/xenbus.c
> @@ -45,6 +45,7 @@
>  #endif
>  
>  struct xenstore_domain_interface *xenstore_buf;
> +EXPORT_SYMBOL(xenstore_buf);
>  static DECLARE_WAIT_QUEUE_HEAD(xb_waitq);
>  DECLARE_WAIT_QUEUE_HEAD(xenbus_watch_queue);
>  static __DECLARE_SEMAPHORE_GENERIC(xb_write_sem, 1);
> @@ -70,6 +71,7 @@ static struct xenbus_req_info req_info[NR_REQS];
>  static char *errmsg(struct xsd_sockmsg *rep);
>  
>  uint32_t xenbus_evtchn;
> +EXPORT_SYMBOL(xenbus_evtchn);
>  
>  #ifdef CONFIG_PARAVIRT
>  void get_xenbus(void *p)
> -- 
> 2.35.3
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.

Re: [PATCH] Mini-OS: add symbol exports for xenstore stubdom

Posted by Jan Beulich 2 months ago

On 26.02.2024 09:39, Juergen Gross wrote:
> Xenstore stubdom needs some more symbols exported.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Any Reported-by: possibly applicable here?

Jan

> --- a/xenbus.c
> +++ b/xenbus.c
> @@ -45,6 +45,7 @@
>  #endif
>  
>  struct xenstore_domain_interface *xenstore_buf;
> +EXPORT_SYMBOL(xenstore_buf);
>  static DECLARE_WAIT_QUEUE_HEAD(xb_waitq);
>  DECLARE_WAIT_QUEUE_HEAD(xenbus_watch_queue);
>  static __DECLARE_SEMAPHORE_GENERIC(xb_write_sem, 1);
> @@ -70,6 +71,7 @@ static struct xenbus_req_info req_info[NR_REQS];
>  static char *errmsg(struct xsd_sockmsg *rep);
>  
>  uint32_t xenbus_evtchn;
> +EXPORT_SYMBOL(xenbus_evtchn);
>  
>  #ifdef CONFIG_PARAVIRT
>  void get_xenbus(void *p)

Re: [PATCH] Mini-OS: add symbol exports for xenstore stubdom

Posted by Jürgen Groß 2 months ago

On 26.02.24 09:44, Jan Beulich wrote:
> On 26.02.2024 09:39, Juergen Gross wrote:
>> Xenstore stubdom needs some more symbols exported.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
> 
> Any Reported-by: possibly applicable here?

If any, then Andrew.

He reported a CI loop failure.


Juergen