[PATCH 0/3] Clean the policy manipulation path in domain creation

Alejandro Vallejo posted 3 patches 5 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20240207173957.19811-1-alejandro.vallejo@cloud.com
There is a newer version of this series
tools/include/xenguest.h             |  14 +-
tools/libs/guest/xg_cpuid_x86.c      | 500 +++++++++------------------
tools/libs/guest/xg_private.h        |  10 -
tools/libs/guest/xg_sr_common_x86.c  |  54 +--
tools/misc/xen-cpuid.c               |  40 +--
xen/include/xen/lib/x86/cpu-policy.h |   6 +-
6 files changed, 197 insertions(+), 427 deletions(-)
[PATCH 0/3] Clean the policy manipulation path in domain creation
Posted by Alejandro Vallejo 5 months, 1 week ago
In the context of creating a domain, we currently issue a lot of hypercalls
redundantly while populating its CPU policy; likely a side effect of
organic growth more than anything else.

However, the worst part is not the overhead (this is a glacially cold
path), but the insane amounts of boilerplate that make it really hard to
pick apart what's going on. One major contributor to this situation is the
fact that what's effectively "setup" and "teardown" phases in policy
manipulation are not factored out from the functions that perform said
manipulations, leading to the same getters and setter being invoked many
times, when once each would do.

Another big contributor is the code being unaware of when a policy is
serialised and when it's not.

This patch attempts to alleviate this situation, yielding over 200 LoC
reduction.

Patch 1: Mechanical change. Makes xc_cpu_policy_t public so it's usable
         from clients of libxc/libxg.
Patch 2: Changes the (de)serialization wrappers in xenguest so they always
         serialise to/from the internal buffers of xc_cpu_policy_t. The
         struct is suitably expanded to hold extra information required.
Patch 3: Performs the refactor of the policy manipulation code so that it
         follows a strict: PULL_POLICIES, MUTATE_POLICY (n times), PUSH_POLICY.

Alejandro Vallejo (3):
  tools/xg: Move xc_cpu_policy_t to xenguest.h
  tools/xg: Streamline cpu policy serialise/deserialise calls
  tools/xg: Clean up xend-style overrides for CPU policies

 tools/include/xenguest.h             |  14 +-
 tools/libs/guest/xg_cpuid_x86.c      | 500 +++++++++------------------
 tools/libs/guest/xg_private.h        |  10 -
 tools/libs/guest/xg_sr_common_x86.c  |  54 +--
 tools/misc/xen-cpuid.c               |  40 +--
 xen/include/xen/lib/x86/cpu-policy.h |   6 +-
 6 files changed, 197 insertions(+), 427 deletions(-)

-- 
2.34.1