[PATCH] x86/cpu: Fix mixed tabs/spaces

Andrew Cooper posted 1 patch 2 weeks, 6 days ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20240205141441.1880188-1-andrew.cooper3@citrix.com
xen/arch/x86/cpu/common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] x86/cpu: Fix mixed tabs/spaces
Posted by Andrew Cooper 2 weeks, 6 days ago
Fixes: 660f8a75013c ("x86/CPU: convert vendor hook invocations to altcall")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/cpu/common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c
index 26eed2ade1e3..28d7f34c4dbe 100644
--- a/xen/arch/x86/cpu/common.c
+++ b/xen/arch/x86/cpu/common.c
@@ -336,8 +336,8 @@ void __init early_cpu_init(bool verbose)
 
 	c->x86_vendor = x86_cpuid_lookup_vendor(ebx, ecx, edx);
 	switch (c->x86_vendor) {
-	case X86_VENDOR_INTEL:	  actual_cpu = intel_cpu_dev;    break;
-	case X86_VENDOR_AMD:	  actual_cpu = amd_cpu_dev;      break;
+	case X86_VENDOR_INTEL:    actual_cpu = intel_cpu_dev;    break;
+	case X86_VENDOR_AMD:      actual_cpu = amd_cpu_dev;      break;
 	case X86_VENDOR_CENTAUR:  actual_cpu = centaur_cpu_dev;  break;
 	case X86_VENDOR_SHANGHAI: actual_cpu = shanghai_cpu_dev; break;
 	case X86_VENDOR_HYGON:    actual_cpu = hygon_cpu_dev;    break;

base-commit: 9eee78988ca081eeed0a69fc9773e2e4268d1ed7
-- 
2.30.2


Re: [PATCH] x86/cpu: Fix mixed tabs/spaces
Posted by Jan Beulich 2 weeks, 6 days ago
On 05.02.2024 15:14, Andrew Cooper wrote:
> Fixes: 660f8a75013c ("x86/CPU: convert vendor hook invocations to altcall")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Without the (or at least this very) Fixes: tag
Acked-by: Jan Beulich <jbeulich@suse.com>
The patch you mention didn't touch the padding at all. (It also didn't
correct the prior inconsistency, but that's mainly because I didn't
even notice.)

Jan

> --- a/xen/arch/x86/cpu/common.c
> +++ b/xen/arch/x86/cpu/common.c
> @@ -336,8 +336,8 @@ void __init early_cpu_init(bool verbose)
>  
>  	c->x86_vendor = x86_cpuid_lookup_vendor(ebx, ecx, edx);
>  	switch (c->x86_vendor) {
> -	case X86_VENDOR_INTEL:	  actual_cpu = intel_cpu_dev;    break;
> -	case X86_VENDOR_AMD:	  actual_cpu = amd_cpu_dev;      break;
> +	case X86_VENDOR_INTEL:    actual_cpu = intel_cpu_dev;    break;
> +	case X86_VENDOR_AMD:      actual_cpu = amd_cpu_dev;      break;
>  	case X86_VENDOR_CENTAUR:  actual_cpu = centaur_cpu_dev;  break;
>  	case X86_VENDOR_SHANGHAI: actual_cpu = shanghai_cpu_dev; break;
>  	case X86_VENDOR_HYGON:    actual_cpu = hygon_cpu_dev;    break;
> 
> base-commit: 9eee78988ca081eeed0a69fc9773e2e4268d1ed7
Re: [PATCH] x86/cpu: Fix mixed tabs/spaces
Posted by Andrew Cooper 2 weeks, 6 days ago
On 05/02/2024 2:33 pm, Jan Beulich wrote:
> On 05.02.2024 15:14, Andrew Cooper wrote:
>> Fixes: 660f8a75013c ("x86/CPU: convert vendor hook invocations to altcall")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Without the (or at least this very) Fixes: tag
> Acked-by: Jan Beulich <jbeulich@suse.com>
> The patch you mention didn't touch the padding at all. (It also didn't
> correct the prior inconsistency, but that's mainly because I didn't
> even notice.)

Oh, right.  I'll drop the fixes tag.

~Andrew