x86/hvm: disable exposing HVM pirqs by default

[PATCH v4 0/2] x86/hvm: disable exposing HVM pirqs by default

Roger Pau Monne posted 2 patches 3 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20240125093041.33087-1-roger.pau@citrix.com

CHANGELOG.md                      |  2 ++
docs/man/xl.cfg.5.pod.in          |  7 +++++++
tools/include/libxl.h             |  7 +++++++
tools/libs/light/libxl_create.c   |  7 +++++--
tools/libs/light/libxl_types.idl  |  1 +
tools/libs/light/libxl_x86.c      | 12 +++++++++---
tools/python/xen/lowlevel/xc/xc.c |  4 +++-
tools/xl/xl_parse.c               |  1 +
xen/arch/x86/domain.c             |  4 +++-
9 files changed, 38 insertions(+), 7 deletions(-)

Expand all Fold all

[PATCH v4 0/2] x86/hvm: disable exposing HVM pirqs by default

Posted by Roger Pau Monne 3 months ago

Hello,

The HVM pirq feature has been found to be buggy on some scenarios, and
given it's an optional feature, and fully undocumented, opt to disable
it by default for the time being.  Note that an xl.cfg option is
provided to allow users to enable it on a per-domain basis.

Domain migrated from older versions also get the feature enabled by
default, in order to keep compatibility.

Thanks, Roger.

Roger Pau Monne (2):
  x86/hvm: make X86_EMU_USE_PIRQ optional
  tools: don't expose XENFEAT_hvm_pirqs by default

 CHANGELOG.md                      |  2 ++
 docs/man/xl.cfg.5.pod.in          |  7 +++++++
 tools/include/libxl.h             |  7 +++++++
 tools/libs/light/libxl_create.c   |  7 +++++--
 tools/libs/light/libxl_types.idl  |  1 +
 tools/libs/light/libxl_x86.c      | 12 +++++++++---
 tools/python/xen/lowlevel/xc/xc.c |  4 +++-
 tools/xl/xl_parse.c               |  1 +
 xen/arch/x86/domain.c             |  4 +++-
 9 files changed, 38 insertions(+), 7 deletions(-)

-- 
2.43.0

Re: [PATCH v4 0/2] x86/hvm: disable exposing HVM pirqs by default

Posted by Andrew Cooper 3 months ago

On 25/01/2024 9:30 am, Roger Pau Monne wrote:
> Hello,
>
> The HVM pirq feature has been found to be buggy on some scenarios, and
> given it's an optional feature, and fully undocumented, opt to disable
> it by default for the time being.  Note that an xl.cfg option is
> provided to allow users to enable it on a per-domain basis.
>
> Domain migrated from older versions also get the feature enabled by
> default, in order to keep compatibility.
>
> Thanks, Roger.
>
> Roger Pau Monne (2):
>   x86/hvm: make X86_EMU_USE_PIRQ optional
>   tools: don't expose XENFEAT_hvm_pirqs by default

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>