[PATCH] CirrusCI: drop FreeBSD 12

Roger Pau Monne posted 1 patch 3 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20240115102718.81294-1-roger.pau@citrix.com
.cirrus.yml | 6 ------
1 file changed, 6 deletions(-)
[PATCH] CirrusCI: drop FreeBSD 12
Posted by Roger Pau Monne 3 months, 1 week ago
Went EOL by the end of December 2023, and the pkg repos have been shut down.

Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 .cirrus.yml | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/.cirrus.yml b/.cirrus.yml
index 385618c394ea..d0a9021a77e4 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -14,12 +14,6 @@ freebsd_template: &FREEBSD_TEMPLATE
     - ./configure --with-system-seabios=/usr/local/share/seabios/bios.bin
     - gmake -j`sysctl -n hw.ncpu` clang=y
 
-task:
-  name: 'FreeBSD 12'
-  freebsd_instance:
-    image_family: freebsd-12-4
-  << : *FREEBSD_TEMPLATE
-
 task:
   name: 'FreeBSD 13'
   freebsd_instance:
-- 
2.43.0


Re: [PATCH] CirrusCI: drop FreeBSD 12
Posted by Andrew Cooper 3 months, 1 week ago
On 15/01/2024 10:27 am, Roger Pau Monne wrote:
> Went EOL by the end of December 2023, and the pkg repos have been shut down.
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

We'll need to backport this, I guess ?

Re: [PATCH] CirrusCI: drop FreeBSD 12
Posted by Roger Pau Monné 3 months, 1 week ago
On Mon, Jan 15, 2024 at 11:01:54AM +0000, Andrew Cooper wrote:
> On 15/01/2024 10:27 am, Roger Pau Monne wrote:
> > Went EOL by the end of December 2023, and the pkg repos have been shut down.
> >
> > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> We'll need to backport this, I guess ?

Yup, but it might not apply cleanly without the rest of the changes to
the file backported also.

Thanks, Roger.

Re: [PATCH] CirrusCI: drop FreeBSD 12
Posted by Jan Beulich 3 months, 1 week ago
On 15.01.2024 12:20, Roger Pau Monné wrote:
> On Mon, Jan 15, 2024 at 11:01:54AM +0000, Andrew Cooper wrote:
>> On 15/01/2024 10:27 am, Roger Pau Monne wrote:
>>> Went EOL by the end of December 2023, and the pkg repos have been shut down.
>>>
>>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>
>> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>
>> We'll need to backport this, I guess ?
> 
> Yup, but it might not apply cleanly without the rest of the changes to
> the file backported also.

Looks to apply fine to .18 and .17, which it what I'll queue it for.
If and when we need it on .16 and/or .15 as well, adjusting the patch
rather then taking further (not really) prereqs may be preferable.

Jan

Re: [PATCH] CirrusCI: drop FreeBSD 12
Posted by Roger Pau Monné 3 months, 1 week ago
On Mon, Jan 15, 2024 at 12:37:39PM +0100, Jan Beulich wrote:
> On 15.01.2024 12:20, Roger Pau Monné wrote:
> > On Mon, Jan 15, 2024 at 11:01:54AM +0000, Andrew Cooper wrote:
> >> On 15/01/2024 10:27 am, Roger Pau Monne wrote:
> >>> Went EOL by the end of December 2023, and the pkg repos have been shut down.
> >>>
> >>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> >>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >>
> >> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> >>
> >> We'll need to backport this, I guess ?
> > 
> > Yup, but it might not apply cleanly without the rest of the changes to
> > the file backported also.
> 
> Looks to apply fine to .18 and .17, which it what I'll queue it for.
> If and when we need it on .16 and/or .15 as well, adjusting the patch
> rather then taking further (not really) prereqs may be preferable.

We would likely need to take backports, because the versions in 15 and
16 CirrusCI file are also EOL, so I think it won't work anyway.

Thanks, Roger.