[v6] Fine granular configuration

[PATCH v6 0/5] Fine granular configuration

Posted by Luca Fancellu 5 months ago

This serie aims to add more modularity to some feature that can be excluded
without issues from the build.

The first patch is already reviewed.

v2 update: So I've tried to see how to put the dom0less code in the common code,
but the amount of modifications are not trivial, even putting only the common
part and protecting them with ARM, leaving the ARM specific stuff under arch/
like gic etc... will leave a status that is not very nice, so I've decided for
now to keep everything on the arm architecture so that who is going to work
on unifying the code in common can just take from there and do the proper
rework.

Luca Fancellu (5):
  arm/gicv2: make GICv2 driver and vGICv2 optional
  xen/arm: Add asm/domain.h include to kernel.h
  arm/dom0less: put dom0less feature code in a separate module
  xen/arm: Move static memory build code in separate modules
  arm/dom0less: introduce Kconfig for dom0less feature

 xen/arch/arm/Kconfig                      |   27 +
 xen/arch/arm/Makefile                     |    7 +-
 xen/arch/arm/arm32/mmu/mm.c               |    1 +
 xen/arch/arm/arm64/mmu/mm.c               |    1 +
 xen/arch/arm/bootfdt.c                    |  161 +-
 xen/arch/arm/dom0less-build.c             | 1018 ++++++
 xen/arch/arm/domain_build.c               | 3591 ++++++---------------
 xen/arch/arm/efi/efi-boot.h               |    4 +
 xen/arch/arm/gic-v3.c                     |    4 +
 xen/arch/arm/include/asm/dom0less-build.h |   30 +
 xen/arch/arm/include/asm/domain_build.h   |   34 +
 xen/arch/arm/include/asm/kernel.h         |    1 +
 xen/arch/arm/include/asm/setup.h          |    2 -
 xen/arch/arm/include/asm/static-memory.h  |   45 +
 xen/arch/arm/include/asm/static-shmem.h   |   66 +
 xen/arch/arm/setup.c                      |   57 +-
 xen/arch/arm/static-memory.c              |  287 ++
 xen/arch/arm/static-shmem.c               |  547 ++++
 xen/arch/arm/vgic.c                       |    2 +
 xen/arch/arm/vgic/Makefile                |    4 +-
 xen/common/Kconfig                        |    2 +-
 21 files changed, 3058 insertions(+), 2833 deletions(-)
 create mode 100644 xen/arch/arm/dom0less-build.c
 create mode 100644 xen/arch/arm/include/asm/dom0less-build.h
 create mode 100644 xen/arch/arm/include/asm/static-memory.h
 create mode 100644 xen/arch/arm/include/asm/static-shmem.h
 create mode 100644 xen/arch/arm/static-memory.c
 create mode 100644 xen/arch/arm/static-shmem.c

-- 
2.34.1

Re: [PATCH v6 0/5] Fine granular configuration

Posted by Luca Fancellu 5 months ago

+ CC Maintainers

> On 24 Nov 2023, at 09:48, Luca Fancellu <luca.fancellu@arm.com> wrote:
> 
> This serie aims to add more modularity to some feature that can be excluded
> without issues from the build.
> 
> The first patch is already reviewed.
> 
> v2 update: So I've tried to see how to put the dom0less code in the common code,
> but the amount of modifications are not trivial, even putting only the common
> part and protecting them with ARM, leaving the ARM specific stuff under arch/
> like gic etc... will leave a status that is not very nice, so I've decided for
> now to keep everything on the arm architecture so that who is going to work
> on unifying the code in common can just take from there and do the proper
> rework.
> 
> Luca Fancellu (5):
>  arm/gicv2: make GICv2 driver and vGICv2 optional
>  xen/arm: Add asm/domain.h include to kernel.h
>  arm/dom0less: put dom0less feature code in a separate module
>  xen/arm: Move static memory build code in separate modules
>  arm/dom0less: introduce Kconfig for dom0less feature
> 
> xen/arch/arm/Kconfig                      |   27 +
> xen/arch/arm/Makefile                     |    7 +-
> xen/arch/arm/arm32/mmu/mm.c               |    1 +
> xen/arch/arm/arm64/mmu/mm.c               |    1 +
> xen/arch/arm/bootfdt.c                    |  161 +-
> xen/arch/arm/dom0less-build.c             | 1018 ++++++
> xen/arch/arm/domain_build.c               | 3591 ++++++---------------
> xen/arch/arm/efi/efi-boot.h               |    4 +
> xen/arch/arm/gic-v3.c                     |    4 +
> xen/arch/arm/include/asm/dom0less-build.h |   30 +
> xen/arch/arm/include/asm/domain_build.h   |   34 +
> xen/arch/arm/include/asm/kernel.h         |    1 +
> xen/arch/arm/include/asm/setup.h          |    2 -
> xen/arch/arm/include/asm/static-memory.h  |   45 +
> xen/arch/arm/include/asm/static-shmem.h   |   66 +
> xen/arch/arm/setup.c                      |   57 +-
> xen/arch/arm/static-memory.c              |  287 ++
> xen/arch/arm/static-shmem.c               |  547 ++++
> xen/arch/arm/vgic.c                       |    2 +
> xen/arch/arm/vgic/Makefile                |    4 +-
> xen/common/Kconfig                        |    2 +-
> 21 files changed, 3058 insertions(+), 2833 deletions(-)
> create mode 100644 xen/arch/arm/dom0less-build.c
> create mode 100644 xen/arch/arm/include/asm/dom0less-build.h
> create mode 100644 xen/arch/arm/include/asm/static-memory.h
> create mode 100644 xen/arch/arm/include/asm/static-shmem.h
> create mode 100644 xen/arch/arm/static-memory.c
> create mode 100644 xen/arch/arm/static-shmem.c

I sent this serie forgetting about adding the maintainers, CC them
now.

Cheers,
Luca

Re: [PATCH v6 0/5] Fine granular configuration

Posted by Luca Fancellu 5 months ago


> On 24 Nov 2023, at 09:59, Luca Fancellu <Luca.Fancellu@arm.com> wrote:
> 
> + CC Maintainers
> 
>> On 24 Nov 2023, at 09:48, Luca Fancellu <luca.fancellu@arm.com> wrote:
>> 
>> This serie aims to add more modularity to some feature that can be excluded
>> without issues from the build.
>> 
>> The first patch is already reviewed.
>> 
>> v2 update: So I've tried to see how to put the dom0less code in the common code,
>> but the amount of modifications are not trivial, even putting only the common
>> part and protecting them with ARM, leaving the ARM specific stuff under arch/
>> like gic etc... will leave a status that is not very nice, so I've decided for
>> now to keep everything on the arm architecture so that who is going to work
>> on unifying the code in common can just take from there and do the proper
>> rework.
>> 
>> Luca Fancellu (5):
>> arm/gicv2: make GICv2 driver and vGICv2 optional
>> xen/arm: Add asm/domain.h include to kernel.h
>> arm/dom0less: put dom0less feature code in a separate module
>> xen/arm: Move static memory build code in separate modules
>> arm/dom0less: introduce Kconfig for dom0less feature
>> 
>> xen/arch/arm/Kconfig                      |   27 +
>> xen/arch/arm/Makefile                     |    7 +-
>> xen/arch/arm/arm32/mmu/mm.c               |    1 +
>> xen/arch/arm/arm64/mmu/mm.c               |    1 +
>> xen/arch/arm/bootfdt.c                    |  161 +-
>> xen/arch/arm/dom0less-build.c             | 1018 ++++++
>> xen/arch/arm/domain_build.c               | 3591 ++++++---------------
>> xen/arch/arm/efi/efi-boot.h               |    4 +
>> xen/arch/arm/gic-v3.c                     |    4 +
>> xen/arch/arm/include/asm/dom0less-build.h |   30 +
>> xen/arch/arm/include/asm/domain_build.h   |   34 +
>> xen/arch/arm/include/asm/kernel.h         |    1 +
>> xen/arch/arm/include/asm/setup.h          |    2 -
>> xen/arch/arm/include/asm/static-memory.h  |   45 +
>> xen/arch/arm/include/asm/static-shmem.h   |   66 +
>> xen/arch/arm/setup.c                      |   57 +-
>> xen/arch/arm/static-memory.c              |  287 ++
>> xen/arch/arm/static-shmem.c               |  547 ++++
>> xen/arch/arm/vgic.c                       |    2 +
>> xen/arch/arm/vgic/Makefile                |    4 +-
>> xen/common/Kconfig                        |    2 +-
>> 21 files changed, 3058 insertions(+), 2833 deletions(-)
>> create mode 100644 xen/arch/arm/dom0less-build.c
>> create mode 100644 xen/arch/arm/include/asm/dom0less-build.h
>> create mode 100644 xen/arch/arm/include/asm/static-memory.h
>> create mode 100644 xen/arch/arm/include/asm/static-shmem.h
>> create mode 100644 xen/arch/arm/static-memory.c
>> create mode 100644 xen/arch/arm/static-shmem.c
> 
> I sent this serie forgetting about adding the maintainers, CC them
> now.

Hi all,

I think all the patches here are Ack-ed by a maintainer, is there any issue to
merge them?

> 
> Cheers,
> Luca
>

Re: [PATCH v6 0/5] Fine granular configuration

Posted by Michal Orzel 5 months ago

Hi Luca,

On 28/11/2023 11:36, Luca Fancellu wrote:
> 
> 
>> On 24 Nov 2023, at 09:59, Luca Fancellu <Luca.Fancellu@arm.com> wrote:
>>
>> + CC Maintainers
>>
>>> On 24 Nov 2023, at 09:48, Luca Fancellu <luca.fancellu@arm.com> wrote:
>>>
>>> This serie aims to add more modularity to some feature that can be excluded
>>> without issues from the build.
>>>
>>> The first patch is already reviewed.
>>>
>>> v2 update: So I've tried to see how to put the dom0less code in the common code,
>>> but the amount of modifications are not trivial, even putting only the common
>>> part and protecting them with ARM, leaving the ARM specific stuff under arch/
>>> like gic etc... will leave a status that is not very nice, so I've decided for
>>> now to keep everything on the arm architecture so that who is going to work
>>> on unifying the code in common can just take from there and do the proper
>>> rework.
>>>
>>> Luca Fancellu (5):
>>> arm/gicv2: make GICv2 driver and vGICv2 optional
>>> xen/arm: Add asm/domain.h include to kernel.h
>>> arm/dom0less: put dom0less feature code in a separate module
>>> xen/arm: Move static memory build code in separate modules
>>> arm/dom0less: introduce Kconfig for dom0less feature
>>>
>>> xen/arch/arm/Kconfig                      |   27 +
>>> xen/arch/arm/Makefile                     |    7 +-
>>> xen/arch/arm/arm32/mmu/mm.c               |    1 +
>>> xen/arch/arm/arm64/mmu/mm.c               |    1 +
>>> xen/arch/arm/bootfdt.c                    |  161 +-
>>> xen/arch/arm/dom0less-build.c             | 1018 ++++++
>>> xen/arch/arm/domain_build.c               | 3591 ++++++---------------
>>> xen/arch/arm/efi/efi-boot.h               |    4 +
>>> xen/arch/arm/gic-v3.c                     |    4 +
>>> xen/arch/arm/include/asm/dom0less-build.h |   30 +
>>> xen/arch/arm/include/asm/domain_build.h   |   34 +
>>> xen/arch/arm/include/asm/kernel.h         |    1 +
>>> xen/arch/arm/include/asm/setup.h          |    2 -
>>> xen/arch/arm/include/asm/static-memory.h  |   45 +
>>> xen/arch/arm/include/asm/static-shmem.h   |   66 +
>>> xen/arch/arm/setup.c                      |   57 +-
>>> xen/arch/arm/static-memory.c              |  287 ++
>>> xen/arch/arm/static-shmem.c               |  547 ++++
>>> xen/arch/arm/vgic.c                       |    2 +
>>> xen/arch/arm/vgic/Makefile                |    4 +-
>>> xen/common/Kconfig                        |    2 +-
>>> 21 files changed, 3058 insertions(+), 2833 deletions(-)
>>> create mode 100644 xen/arch/arm/dom0less-build.c
>>> create mode 100644 xen/arch/arm/include/asm/dom0less-build.h
>>> create mode 100644 xen/arch/arm/include/asm/static-memory.h
>>> create mode 100644 xen/arch/arm/include/asm/static-shmem.h
>>> create mode 100644 xen/arch/arm/static-memory.c
>>> create mode 100644 xen/arch/arm/static-shmem.c
>>
>> I sent this serie forgetting about adding the maintainers, CC them
>> now.
> 
> Hi all,
> 
> I think all the patches here are Ack-ed by a maintainer, is there any issue to
> merge them?
We discussed this on Matrix and Julien will take care of committing this week.

~Michal

Re: [PATCH v6 0/5] Fine granular configuration

Posted by Luca Fancellu 5 months ago


> On 28 Nov 2023, at 12:38, Michal Orzel <michal.orzel@amd.com> wrote:
> 
> Hi Luca,
> 
> On 28/11/2023 11:36, Luca Fancellu wrote:
>> 
>> 
>>> On 24 Nov 2023, at 09:59, Luca Fancellu <Luca.Fancellu@arm.com> wrote:
>>> 
>>> + CC Maintainers
>>> 
>>>> On 24 Nov 2023, at 09:48, Luca Fancellu <luca.fancellu@arm.com> wrote:
>>>> 
>>>> This serie aims to add more modularity to some feature that can be excluded
>>>> without issues from the build.
>>>> 
>>>> The first patch is already reviewed.
>>>> 
>>>> v2 update: So I've tried to see how to put the dom0less code in the common code,
>>>> but the amount of modifications are not trivial, even putting only the common
>>>> part and protecting them with ARM, leaving the ARM specific stuff under arch/
>>>> like gic etc... will leave a status that is not very nice, so I've decided for
>>>> now to keep everything on the arm architecture so that who is going to work
>>>> on unifying the code in common can just take from there and do the proper
>>>> rework.
>>>> 
>>>> Luca Fancellu (5):
>>>> arm/gicv2: make GICv2 driver and vGICv2 optional
>>>> xen/arm: Add asm/domain.h include to kernel.h
>>>> arm/dom0less: put dom0less feature code in a separate module
>>>> xen/arm: Move static memory build code in separate modules
>>>> arm/dom0less: introduce Kconfig for dom0less feature
>>>> 
>>>> xen/arch/arm/Kconfig                      |   27 +
>>>> xen/arch/arm/Makefile                     |    7 +-
>>>> xen/arch/arm/arm32/mmu/mm.c               |    1 +
>>>> xen/arch/arm/arm64/mmu/mm.c               |    1 +
>>>> xen/arch/arm/bootfdt.c                    |  161 +-
>>>> xen/arch/arm/dom0less-build.c             | 1018 ++++++
>>>> xen/arch/arm/domain_build.c               | 3591 ++++++---------------
>>>> xen/arch/arm/efi/efi-boot.h               |    4 +
>>>> xen/arch/arm/gic-v3.c                     |    4 +
>>>> xen/arch/arm/include/asm/dom0less-build.h |   30 +
>>>> xen/arch/arm/include/asm/domain_build.h   |   34 +
>>>> xen/arch/arm/include/asm/kernel.h         |    1 +
>>>> xen/arch/arm/include/asm/setup.h          |    2 -
>>>> xen/arch/arm/include/asm/static-memory.h  |   45 +
>>>> xen/arch/arm/include/asm/static-shmem.h   |   66 +
>>>> xen/arch/arm/setup.c                      |   57 +-
>>>> xen/arch/arm/static-memory.c              |  287 ++
>>>> xen/arch/arm/static-shmem.c               |  547 ++++
>>>> xen/arch/arm/vgic.c                       |    2 +
>>>> xen/arch/arm/vgic/Makefile                |    4 +-
>>>> xen/common/Kconfig                        |    2 +-
>>>> 21 files changed, 3058 insertions(+), 2833 deletions(-)
>>>> create mode 100644 xen/arch/arm/dom0less-build.c
>>>> create mode 100644 xen/arch/arm/include/asm/dom0less-build.h
>>>> create mode 100644 xen/arch/arm/include/asm/static-memory.h
>>>> create mode 100644 xen/arch/arm/include/asm/static-shmem.h
>>>> create mode 100644 xen/arch/arm/static-memory.c
>>>> create mode 100644 xen/arch/arm/static-shmem.c
>>> 
>>> I sent this serie forgetting about adding the maintainers, CC them
>>> now.
>> 
>> Hi all,
>> 
>> I think all the patches here are Ack-ed by a maintainer, is there any issue to
>> merge them?
> We discussed this on Matrix and Julien will take care of committing this week.

Ok understood, thanks 

> 
> ~Michal
>