1. Patchew
  2. Xen
  3. View series

[PATCH] xen/arm: Add Rockchip rk3399 early printk support

Jun Nie posted 1 patch 6 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20231026054634.2805035-1-jun.nie@linaro.org
xen/arch/arm/Kconfig.debug | 5 +++++
1 file changed, 5 insertions(+)
[PATCH] xen/arm: Add Rockchip rk3399 early printk support
Posted by Jun Nie 6 months, 1 week ago 
Signed-off-by: Jun Nie <jun.nie@linaro.org>
---
 xen/arch/arm/Kconfig.debug | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
index 842d768280..fefe8ac4df 100644
--- a/xen/arch/arm/Kconfig.debug
+++ b/xen/arch/arm/Kconfig.debug
@@ -158,6 +158,9 @@ choice
 	config EARLY_PRINTK_RCAR3
 		bool "Early printk with SCIF2 on Renesas R-Car Gen3 processors"
 		select EARLY_UART_SCIF
+	config EARLY_PRINTK_RK3399
+		bool "Early printk with 8250 on Rockchip RK3399 processors"
+		select EARLY_UART_8250
 	config EARLY_PRINTK_SEATTLE
 		bool "Early printk with pl011 for AMD Seattle processor"
 		select EARLY_UART_PL011
@@ -230,6 +233,7 @@ config EARLY_UART_BASE_ADDRESS
 	default 0xd0012000 if EARLY_PRINTK_MVEBU
 	default 0x48020000 if EARLY_PRINTK_OMAP5432
 	default 0xe6e88000 if EARLY_PRINTK_RCAR3
+	default 0xff1a0000 if EARLY_PRINTK_RK3399
 	default 0xe1010000 if EARLY_PRINTK_SEATTLE
 	default 0x01c28000 if EARLY_PRINTK_SUN6I
 	default 0x01c28000 if EARLY_PRINTK_SUN7I
@@ -270,6 +274,7 @@ config EARLY_UART_8250_REG_SHIFT
 	default 2 if EARLY_PRINTK_BRCM
 	default 2 if EARLY_PRINTK_DRA7
 	default 2 if EARLY_PRINTK_OMAP5432
+	default 2 if EARLY_PRINTK_RK3399
 	default 2 if EARLY_PRINTK_SUN6I
 	default 2 if EARLY_PRINTK_SUN7I
 	default 2 if EARLY_PRINTK_XGENE_MCDIVITT
-- 
2.34.1
Re: [PATCH] xen/arm: Add Rockchip rk3399 early printk support
Posted by Michal Orzel 6 months, 1 week ago 
Hi,

On 26/10/2023 07:46, Jun Nie wrote:
> 
> 
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
> ---
>  xen/arch/arm/Kconfig.debug | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
> index 842d768280..fefe8ac4df 100644
> --- a/xen/arch/arm/Kconfig.debug
> +++ b/xen/arch/arm/Kconfig.debug
> @@ -158,6 +158,9 @@ choice
>         config EARLY_PRINTK_RCAR3
>                 bool "Early printk with SCIF2 on Renesas R-Car Gen3 processors"
>                 select EARLY_UART_SCIF
> +       config EARLY_PRINTK_RK3399
> +               bool "Early printk with 8250 on Rockchip RK3399 processors"
> +               select EARLY_UART_8250
Platform specific options for early printk are deprecated. You can read it at the top of the file:
"
Deprecated: Alternatively, there are platform specific options
which will have default values for the various parameters. But
such option will soon be removed.
"

~Michal
Re: [PATCH] xen/arm: Add Rockchip rk3399 early printk support
Posted by Jun Nie 6 months, 1 week ago 
Michal Orzel <michal.orzel@amd.com> 于2023年10月26日周四 15:02写道：
>
> Hi,
>
> On 26/10/2023 07:46, Jun Nie wrote:
> >
> >
> > Signed-off-by: Jun Nie <jun.nie@linaro.org>
> > ---
> >  xen/arch/arm/Kconfig.debug | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
> > index 842d768280..fefe8ac4df 100644
> > --- a/xen/arch/arm/Kconfig.debug
> > +++ b/xen/arch/arm/Kconfig.debug
> > @@ -158,6 +158,9 @@ choice
> >         config EARLY_PRINTK_RCAR3
> >                 bool "Early printk with SCIF2 on Renesas R-Car Gen3 processors"
> >                 select EARLY_UART_SCIF
> > +       config EARLY_PRINTK_RK3399
> > +               bool "Early printk with 8250 on Rockchip RK3399 processors"
> > +               select EARLY_UART_8250
> Platform specific options for early printk are deprecated. You can read it at the top of the file:
> "
> Deprecated: Alternatively, there are platform specific options
> which will have default values for the various parameters. But
> such option will soon be removed.
> "
>
> ~Michal


Thanks for the reminder! So only below 2 configs shall be configured
when compiling the project, right?

EARLY_UART_BASE_ADDRESS
EARLY_UART_8250_REG_SHIFT

- Jun
Re: [PATCH] xen/arm: Add Rockchip rk3399 early printk support
Posted by Michal Orzel 6 months, 1 week ago 

On 26/10/2023 09:22, Jun Nie wrote:
> 
> 
> Michal Orzel <michal.orzel@amd.com> 于2023年10月26日周四 15:02写道：
>>
>> Hi,
>>
>> On 26/10/2023 07:46, Jun Nie wrote:
>>>
>>>
>>> Signed-off-by: Jun Nie <jun.nie@linaro.org>
>>> ---
>>>  xen/arch/arm/Kconfig.debug | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
>>> index 842d768280..fefe8ac4df 100644
>>> --- a/xen/arch/arm/Kconfig.debug
>>> +++ b/xen/arch/arm/Kconfig.debug
>>> @@ -158,6 +158,9 @@ choice
>>>         config EARLY_PRINTK_RCAR3
>>>                 bool "Early printk with SCIF2 on Renesas R-Car Gen3 processors"
>>>                 select EARLY_UART_SCIF
>>> +       config EARLY_PRINTK_RK3399
>>> +               bool "Early printk with 8250 on Rockchip RK3399 processors"
>>> +               select EARLY_UART_8250
>> Platform specific options for early printk are deprecated. You can read it at the top of the file:
>> "
>> Deprecated: Alternatively, there are platform specific options
>> which will have default values for the various parameters. But
>> such option will soon be removed.
>> "
>>
>> ~Michal
> 
> 
> Thanks for the reminder! So only below 2 configs shall be configured
> when compiling the project, right?
> 
> EARLY_UART_BASE_ADDRESS
> EARLY_UART_8250_REG_SHIFT

Yes, that's correct

~Michal

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.