[PATCH v4 01/10] xen/arm: remove stale addr_cells/size_cells in assign_shared_memory

Penny Zheng posted 10 patches 1 year, 4 months ago
There is a newer version of this series
[PATCH v4 01/10] xen/arm: remove stale addr_cells/size_cells in assign_shared_memory
Posted by Penny Zheng 1 year, 4 months ago
Function parameters {addr_cells,size_cells} are stale parameters in
assign_shared_memory, so we shall remove them.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v1 -> v2:
- new commit
---
v2 -> v3:
rebase and no change
---
v3 -> v4:
rebase and no change
---
 xen/arch/arm/domain_build.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 29dcbb8a2e..c532fa882c 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -858,7 +858,6 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d,
 }
 
 static int __init assign_shared_memory(struct domain *d,
-                                       uint32_t addr_cells, uint32_t size_cells,
                                        paddr_t pbase, paddr_t psize,
                                        paddr_t gbase)
 {
@@ -1020,7 +1019,6 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo,
              * specified, so they should be assigned to dom_io.
              */
             ret = assign_shared_memory(owner_dom_io ? dom_io : d,
-                                       addr_cells, size_cells,
                                        pbase, psize, gbase);
             if ( ret )
                 return ret;
-- 
2.25.1
Re: [PATCH v4 01/10] xen/arm: remove stale addr_cells/size_cells in assign_shared_memory
Posted by Michal Orzel 1 year, 4 months ago
Hi Penny,

On 11/09/2023 06:04, Penny Zheng wrote:
> 
> 
> Function parameters {addr_cells,size_cells} are stale parameters in
> assign_shared_memory, so we shall remove them.
> 
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Reviewed-by: Michal Orzel <michal.orzel@amd.com>

~Michal