[v3] vPCI capabilities filtering

[PATCH v3 0/4] vPCI capabilities filtering

Stewart Hildebrand posted 4 patches 8 months, 1 week ago

Diff against v1 v2 v4 v5 v6 v7 v8 v9 v10
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20230822012955.312930-1-stewart.hildebrand@amd.com

There is a newer version of this series

xen/arch/x86/msi.c                         | 47 +++--------
xen/drivers/char/ehci-dbgp.c               |  3 +-
xen/drivers/passthrough/amd/iommu_detect.c |  2 +-
xen/drivers/passthrough/ats.c              |  4 +-
xen/drivers/passthrough/ats.h              |  6 +-
xen/drivers/passthrough/msi.c              |  6 +-
xen/drivers/passthrough/pci.c              | 20 ++---
xen/drivers/passthrough/vtd/quirks.c       | 10 +--
xen/drivers/passthrough/vtd/x86/ats.c      |  3 +-
xen/drivers/pci/pci.c                      | 50 +++++++-----
xen/drivers/vpci/header.c                  | 93 ++++++++++++++++++++++
xen/drivers/vpci/msi.c                     |  4 +-
xen/drivers/vpci/msix.c                    |  4 +-
xen/drivers/vpci/vpci.c                    | 53 +++++++++---
xen/include/xen/pci.h                      | 11 ++-
xen/include/xen/vpci.h                     | 14 ++++
16 files changed, 221 insertions(+), 109 deletions(-)

Expand all Fold all

[PATCH v3 0/4] vPCI capabilities filtering

Posted by Stewart Hildebrand 8 months, 1 week ago

This small series enables vPCI to filter which PCI capabilities we expose to a
domU. This series adds vPCI register handlers within
xen/drivers/vpci/header.c:init_bars(), along with some supporting functions.

Note there are minor rebase conflicts with the in-progress vPCI series [1].
These conflicts fall into the category of functions and code being added
adjacent to one another, so are easily resolved. I did not identify any
dependency on the vPCI locking work, and the two series deal with different
aspects of emulating the PCI header.

Future work may involve adding handlers for more registers in the vPCI header,
such as VID/DID, etc. Future work may also involve exposing additional
capabilities to the guest for broader device/driver support.

v2->v3:
* drop RFC "xen/vpci: header: avoid cast for value passed to vpci_read_val"
* minor misra C violation fixup in preparatory patch
* switch to pci_sbdf_t in preparatory patch
* introduce status handler

v1->v2:
* squash helper functions into the patch where they are used to avoid transient
  dead code situation
* add new RFC patch, possibly throwaway, to get an idea of what it would look
  like to get rid of the (void *)(uintptr_t) cast by introducing a new memory
  allocation

[1] https://lists.xenproject.org/archives/html/xen-devel/2023-07/msg01281.html

Stewart Hildebrand (4):
  xen/pci: address a violation of MISRA C:2012 Rule 8.3
  xen/pci: convert pci_find_*cap* to pci_sbdf_t
  xen/vpci: header: filter PCI capabilities
  xen/vpci: header: status register handler

 xen/arch/x86/msi.c                         | 47 +++--------
 xen/drivers/char/ehci-dbgp.c               |  3 +-
 xen/drivers/passthrough/amd/iommu_detect.c |  2 +-
 xen/drivers/passthrough/ats.c              |  4 +-
 xen/drivers/passthrough/ats.h              |  6 +-
 xen/drivers/passthrough/msi.c              |  6 +-
 xen/drivers/passthrough/pci.c              | 20 ++---
 xen/drivers/passthrough/vtd/quirks.c       | 10 +--
 xen/drivers/passthrough/vtd/x86/ats.c      |  3 +-
 xen/drivers/pci/pci.c                      | 50 +++++++-----
 xen/drivers/vpci/header.c                  | 93 ++++++++++++++++++++++
 xen/drivers/vpci/msi.c                     |  4 +-
 xen/drivers/vpci/msix.c                    |  4 +-
 xen/drivers/vpci/vpci.c                    | 53 +++++++++---
 xen/include/xen/pci.h                      | 11 ++-
 xen/include/xen/vpci.h                     | 14 ++++
 16 files changed, 221 insertions(+), 109 deletions(-)


base-commit: 3fae7c56b313a12288a05e0a8c14c47bfd4dc40e
-- 
2.41.0