xen: xenbus: Use helper function IS_ERR_OR_NULL()

[PATCH -next] xen: xenbus: Use helper function IS_ERR_OR_NULL()

Li Zetao posted 1 patch 8 months, 2 weeks ago

Download mbox

Failed in applying to current master (apply log)

drivers/xen/xenbus/xenbus_probe_frontend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH -next] xen: xenbus: Use helper function IS_ERR_OR_NULL()

Posted by Li Zetao 8 months, 2 weeks ago

Use IS_ERR_OR_NULL() to detect an error pointer or a null pointer
open-coding to simplify the code.

Signed-off-by: Li Zetao <lizetao1@huawei.com>
---
 drivers/xen/xenbus/xenbus_probe_frontend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/xenbus/xenbus_probe_frontend.c b/drivers/xen/xenbus/xenbus_probe_frontend.c
index 3f3836cb7279..fcb335bb7b18 100644
--- a/drivers/xen/xenbus/xenbus_probe_frontend.c
+++ b/drivers/xen/xenbus/xenbus_probe_frontend.c
@@ -429,7 +429,7 @@ static void xenbus_check_frontend(char *class, char *dev)
 		printk(KERN_DEBUG "XENBUS: frontend %s %s\n",
 				frontend, xenbus_strstate(fe_state));
 		backend = xenbus_read(XBT_NIL, frontend, "backend", NULL);
-		if (!backend || IS_ERR(backend))
+		if (IS_ERR_OR_NULL(backend))
 			goto out;
 		err = xenbus_scanf(XBT_NIL, backend, "state", "%i", &be_state);
 		if (err == 1)
-- 
2.34.1

Re: [PATCH -next] xen: xenbus: Use helper function IS_ERR_OR_NULL()

Posted by Juergen Gross 8 months, 1 week ago

On 17.08.23 03:47, Li Zetao wrote:
> Use IS_ERR_OR_NULL() to detect an error pointer or a null pointer
> open-coding to simplify the code.
> 
> Signed-off-by: Li Zetao <lizetao1@huawei.com>

Pushed to xen/tip.git for-linus-6.6


Juergen