From: Stefano Stabellini <stefano.stabellini@amd.com>
The test artifacts export jobs don't need prerequisites, so we should
specify "needs" with an empty array for them. That way, they are not
going to fruitlessly wait for previous jobs (ECLAIR jobs) to complete
before continuing.
Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
automation/gitlab-ci/build.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index f01e2c32bb..af64a53ead 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -268,6 +268,7 @@
.test-jobs-artifact-common:
stage: build
+ needs: []
except: !reference [.test-jobs-common, except]
# Arm test artifacts
--
2.25.1
On 04/08/2023 03:10, Stefano Stabellini wrote: > > > From: Stefano Stabellini <stefano.stabellini@amd.com> > > The test artifacts export jobs don't need prerequisites, so we should > specify "needs" with an empty array for them. That way, they are not > going to fruitlessly wait for previous jobs (ECLAIR jobs) to complete > before continuing. > > Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com> Reviewed-by: Michal Orzel <michal.orzel@amd.com> Looking at the whole pipeline, I can see that now only ECLAIR jobs do not specify needs. Shouldn't we also add "needs: []" for them? ~Michal
On Fri, 3 Aug 2023, Michal Orzel wrote: > On 04/08/2023 03:10, Stefano Stabellini wrote: > > > > > > From: Stefano Stabellini <stefano.stabellini@amd.com> > > > > The test artifacts export jobs don't need prerequisites, so we should > > specify "needs" with an empty array for them. That way, they are not > > going to fruitlessly wait for previous jobs (ECLAIR jobs) to complete > > before continuing. > > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com> > Reviewed-by: Michal Orzel <michal.orzel@amd.com> Thanks! > Looking at the whole pipeline, I can see that now only ECLAIR jobs do not specify needs. > Shouldn't we also add "needs: []" for them? Yes it could be good for consistency and future-proofness, but technically it is not required now because the ECLAIR jobs come first.
© 2016 - 2024 Red Hat, Inc.