x86: Some MISRA Rule 5.3 fixes

[PATCH 0/3] x86: Some MISRA Rule 5.3 fixes

Andrew Cooper posted 3 patches 9 months, 2 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20230728194320.3082120-1-andrew.cooper3@citrix.com

xen/arch/x86/hvm/svm/svm.c           |   2 -
xen/arch/x86/include/asm/desc.h      |   9 --
xen/arch/x86/include/asm/processor.h |  34 +---
xen/arch/x86/pv/traps.c              |   2 +
xen/arch/x86/traps.c                 | 227 ++++++++++++++-------------
xen/arch/x86/x86_64/entry.S          |  36 ++---
6 files changed, 142 insertions(+), 168 deletions(-)

Expand all Fold all

[PATCH 0/3] x86: Some MISRA Rule 5.3 fixes

Posted by Andrew Cooper 9 months, 2 weeks ago

'debug' and 'str' account for an awefully large number of shadowed variable
violations.

Andrew Cooper (3):
  x86/traps: Move do_general_protection() earlier
  x86/entry: Rename the exception entrypoints
  x86: Delete str()

 xen/arch/x86/hvm/svm/svm.c           |   2 -
 xen/arch/x86/include/asm/desc.h      |   9 --
 xen/arch/x86/include/asm/processor.h |  34 +---
 xen/arch/x86/pv/traps.c              |   2 +
 xen/arch/x86/traps.c                 | 227 ++++++++++++++-------------
 xen/arch/x86/x86_64/entry.S          |  36 ++---
 6 files changed, 142 insertions(+), 168 deletions(-)


base-commit: dbd566ab729d2839c3c0be5c47cdcc06c2c477f0
-- 
2.30.2

Re: [PATCH 0/3] x86: Some MISRA Rule 5.3 fixes

Posted by Jan Beulich 9 months, 2 weeks ago

On 28.07.2023 21:43, Andrew Cooper wrote:
> 'debug' and 'str' account for an awefully large number of shadowed variable
> violations.
> 
> Andrew Cooper (3):
>   x86/traps: Move do_general_protection() earlier
>   x86/entry: Rename the exception entrypoints
>   x86: Delete str()

Series
Acked-by: Jan Beulich <jbeulich@suse.com>
with a slightly amended description in patch 3, and preferably also with
at least mentioning the Misra angle in patch 2.

Jan