Since QEMU commit 74a1b256d775 ("configure: Bump minimum Clang version
to 10.0"), or QEMU v8.0, Clang 10.0 is now the minimum to build QEMU.
QEMU 8.0 fails to build on Ubuntu Bionic.
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
Notes:
I've tested that change here, with QEMU v8.0.2:
https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/902576734
automation/scripts/build | 2 ++
1 file changed, 2 insertions(+)
diff --git a/automation/scripts/build b/automation/scripts/build
index 38c48ae6d8..b4edcf010e 100755
--- a/automation/scripts/build
+++ b/automation/scripts/build
@@ -78,7 +78,9 @@ else
fi
# Qemu requires Python 3.5 or later, and ninja
+ # and Clang 10 or later
if ! type python3 || python3 -c "import sys; res = sys.version_info < (3, 5); exit(not(res))" \
+ || [[ "$cc_is_clang" == y && "$cc_ver" -lt 0x0a0000 ]] \
|| ! type ninja; then
cfgargs+=("--with-system-qemu=/bin/false")
fi
--
Anthony PERARD
On Mon, 19 Jun 2023, Anthony PERARD wrote: > Since QEMU commit 74a1b256d775 ("configure: Bump minimum Clang version > to 10.0"), or QEMU v8.0, Clang 10.0 is now the minimum to build QEMU. > > QEMU 8.0 fails to build on Ubuntu Bionic. > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> Acked-by: Stefano Stabellini <sstabellini@kernel.org> > --- > > Notes: > I've tested that change here, with QEMU v8.0.2: > https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/902576734 > > automation/scripts/build | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/automation/scripts/build b/automation/scripts/build > index 38c48ae6d8..b4edcf010e 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -78,7 +78,9 @@ else > fi > > # Qemu requires Python 3.5 or later, and ninja > + # and Clang 10 or later > if ! type python3 || python3 -c "import sys; res = sys.version_info < (3, 5); exit(not(res))" \ > + || [[ "$cc_is_clang" == y && "$cc_ver" -lt 0x0a0000 ]] \ > || ! type ninja; then > cfgargs+=("--with-system-qemu=/bin/false") > fi > -- > Anthony PERARD >
On 19/06/2023 10:09 am, Anthony PERARD wrote: > Since QEMU commit 74a1b256d775 ("configure: Bump minimum Clang version > to 10.0"), or QEMU v8.0, Clang 10.0 is now the minimum to build QEMU. > > QEMU 8.0 fails to build on Ubuntu Bionic. > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> Lovely... Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
© 2016 - 2024 Red Hat, Inc.