[PATCH] docs: Fix xl.cfg documentation

Luca Fancellu posted 1 patch 11 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20230607135419.3498902-1-luca.fancellu@arm.com
docs/man/xl.cfg.5.pod.in | 2 ++
1 file changed, 2 insertions(+)
[PATCH] docs: Fix xl.cfg documentation
Posted by Luca Fancellu 11 months, 1 week ago
A recent change to the documentation for the xl.cfg introduced a build
error, fix the issue.

Fixes: b46e8207d0ae ("xen/tools: add sve parameter in XL configuration")
Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
Apologise for the error! I think I was building an old version of the docs and
after the clarification from Andrew about refreshing the files with ./configure
I was able to reproduce the issue.
I didn't put any tag like Reported-by/Suggested-by because I don't know if they
can be put here? Anyway I guess it can be done on commit, Andrew reported the
issue and Michal was quick enough to suggest the fix before I've started working
on it :)
---
 docs/man/xl.cfg.5.pod.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index 1b4e13ab647b..3979be2a590a 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -2955,6 +2955,8 @@ Currently, only the "sbsa_uart" model is supported for ARM.
 
 =back
 
+=over 4
+
 =item B<sve="vl">
 
 The `sve` parameter enables Arm Scalable Vector Extension (SVE) usage for the
-- 
2.34.1
Re: [PATCH] docs: Fix xl.cfg documentation
Posted by Michal Orzel 11 months, 1 week ago
On 07/06/2023 15:54, Luca Fancellu wrote:
> 
> 
> A recent change to the documentation for the xl.cfg introduced a build
> error, fix the issue.
> 
> Fixes: b46e8207d0ae ("xen/tools: add sve parameter in XL configuration")
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>

Tested and looks good.

Reviewed-by: Michal Orzel <michal.orzel@amd.com>
Tested-by: Michal Orzel <michal.orzel@amd.com>

~Michal
Re: [PATCH] docs: Fix xl.cfg documentation
Posted by Andrew Cooper 11 months, 1 week ago
On 07/06/2023 2:59 pm, Michal Orzel wrote:
> On 07/06/2023 15:54, Luca Fancellu wrote:
>>
>> A recent change to the documentation for the xl.cfg introduced a build
>> error, fix the issue.
>>
>> Fixes: b46e8207d0ae ("xen/tools: add sve parameter in XL configuration")
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> Tested and looks good.
>
> Reviewed-by: Michal Orzel <michal.orzel@amd.com>
> Tested-by: Michal Orzel <michal.orzel@amd.com>

Committed, thanks.

~Andrew