[patch V2 34/38] x86/cpu/amd; Invoke detect_extended_topology_early() on boot CPU

Thomas Gleixner posted 38 patches 2 years, 9 months ago
There is a newer version of this series
[patch V2 34/38] x86/cpu/amd; Invoke detect_extended_topology_early() on boot CPU
Posted by Thomas Gleixner 2 years, 9 months ago
From: Thomas Gleixner <tglx@linutronix.de>

The early detection stores the extended topology leaf number which is
required for parallel hotplug.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 arch/x86/kernel/cpu/amd.c |    2 ++
 1 file changed, 2 insertions(+)
---
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -692,6 +692,8 @@ static void early_init_amd(struct cpuinf
 		}
 	}
 
+	detect_extended_topology_early(c);
+
 	if (cpu_has(c, X86_FEATURE_TOPOEXT))
 		smp_num_siblings = ((cpuid_ebx(0x8000001e) >> 8) & 0xff) + 1;
 }
Re: [patch V2 34/38] x86/cpu/amd; Invoke detect_extended_topology_early() on boot CPU
Posted by Andrew Cooper 2 years, 9 months ago
On 04/05/2023 8:02 pm, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
>
> The early detection stores the extended topology leaf number which is
> required for parallel hotplug.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

It occurs to me that this and the previous patch are stale given that we
no longer look at CPUID in the trampoline.

They're probably useful changes in isolation, but the commit messages
want adjusting to remove the association with parallel boot.

~Andrew
Re: [patch V2 34/38] x86/cpu/amd; Invoke detect_extended_topology_early() on boot CPU
Posted by Thomas Gleixner 2 years, 9 months ago
On Fri, May 05 2023 at 00:04, Andrew Cooper wrote:
> On 04/05/2023 8:02 pm, Thomas Gleixner wrote:
>> From: Thomas Gleixner <tglx@linutronix.de>
>>
>> The early detection stores the extended topology leaf number which is
>> required for parallel hotplug.
>>
>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
> It occurs to me that this and the previous patch are stale given that we
> no longer look at CPUID in the trampoline.
>
> They're probably useful changes in isolation, but the commit messages
> want adjusting to remove the association with parallel boot.

Duh. Indeed. Completely forgot about that.