[v1] CHANGELOG: add gnttab_max_{maptrack_,}frames option changes

[PATCH] CHANGELOG: add gnttab_max_{maptrack_,}frames option changes

Posted by Roger Pau Monne 1 year ago

Note in the changelog that the purpose of
gnttab_max_{maptrack_,}frames command line options has been changed.

Fixes: b2ea81d2b935 ('xen/grants: repurpose command line max options')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 CHANGELOG.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index c978cfd9b68f..2a7e62495104 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
    - Bus-lock detection, used by Xen to mitigate (by rate-limiting) the system
      wide impact of a guest misusing atomic instructions.
  - xl/libxl can customize SMBIOS strings for HVM guests.
+ - Repurpose command line gnttab_max_{maptrack_,}frames options so they don't
+   cap toolstack provided values.
 
 ## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.17.0) - 2022-12-12
 
-- 
2.40.0

RE: [PATCH] CHANGELOG: add gnttab_max_{maptrack_,}frames option changes

Posted by Henry Wang 1 year ago

Hi Roger,

> -----Original Message-----
> From: Roger Pau Monne <roger.pau@citrix.com>
> Subject: [PATCH] CHANGELOG: add gnttab_max_{maptrack_,}frames option
> changes
> 
> Note in the changelog that the purpose of
> gnttab_max_{maptrack_,}frames command line options has been changed.

Thanks for remembering this!

> 
> Fixes: b2ea81d2b935 ('xen/grants: repurpose command line max options')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
>  CHANGELOG.md | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index c978cfd9b68f..2a7e62495104 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -14,6 +14,8 @@ The format is based on [Keep a
> Changelog](https://keepachangelog.com/en/1.0.0/)
>     - Bus-lock detection, used by Xen to mitigate (by rate-limiting) the system
>       wide impact of a guest misusing atomic instructions.
>   - xl/libxl can customize SMBIOS strings for HVM guests.
> + - Repurpose command line gnttab_max_{maptrack_,}frames options so
> they don't
> +   cap toolstack provided values.

However, seeing the title and the "repurpose" here, may I please suggest
adding a "### Changed" section on top of the "### Added" section and
move the "gnttab_max_{maptrack_,}frames option changes" entry there?

I think this can be done on commit if you agree (and also the committer
would like to do the favor for us), so:

Acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry