[PATCH] automation: switch ADL hw tests to debug build

Marek Marczykowski-Górecki posted 1 patch 1 year ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20230413122340.47233-1-marmarek@invisiblethingslab.com
automation/gitlab-ci/test.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
[PATCH] automation: switch ADL hw tests to debug build
Posted by Marek Marczykowski-Górecki 1 year ago
This should give a lot more useful information in case of a failure, and
also enable some asserts for extra checks.

Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---
 automation/gitlab-ci/test.yaml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
index 0916b367ea90..d68c584269dd 100644
--- a/automation/gitlab-ci/test.yaml
+++ b/automation/gitlab-ci/test.yaml
@@ -131,21 +131,21 @@ xilinx-smoke-dom0less-arm64-gcc:
     - *arm64-test-needs
     - alpine-3.12-gcc-arm64
 
-adl-smoke-x86-64-gcc:
+adl-smoke-x86-64-gcc-debug:
   extends: .adl-x86-64
   script:
     - ./automation/scripts/qubes-x86-64.sh 2>&1 | tee ${LOGFILE}
   needs:
     - *x86-64-test-needs
-    - alpine-3.12-gcc
+    - alpine-3.12-gcc-debug
 
-adl-suspend-x86-64-gcc:
+adl-suspend-x86-64-gcc-debug:
   extends: .adl-x86-64
   script:
     - ./automation/scripts/qubes-x86-64.sh s3 2>&1 | tee ${LOGFILE}
   needs:
     - *x86-64-test-needs
-    - alpine-3.12-gcc
+    - alpine-3.12-gcc-debug
 
 qemu-smoke-dom0-arm64-gcc:
   extends: .qemu-arm64
-- 
2.39.2


Re: [PATCH] automation: switch ADL hw tests to debug build
Posted by Stefano Stabellini 1 year ago
On Thu, 13 Apr 2023, Marek Marczykowski-Górecki wrote:
> This should give a lot more useful information in case of a failure, and
> also enable some asserts for extra checks.
> 
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  automation/gitlab-ci/test.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
> index 0916b367ea90..d68c584269dd 100644
> --- a/automation/gitlab-ci/test.yaml
> +++ b/automation/gitlab-ci/test.yaml
> @@ -131,21 +131,21 @@ xilinx-smoke-dom0less-arm64-gcc:
>      - *arm64-test-needs
>      - alpine-3.12-gcc-arm64
>  
> -adl-smoke-x86-64-gcc:
> +adl-smoke-x86-64-gcc-debug:
>    extends: .adl-x86-64
>    script:
>      - ./automation/scripts/qubes-x86-64.sh 2>&1 | tee ${LOGFILE}
>    needs:
>      - *x86-64-test-needs
> -    - alpine-3.12-gcc
> +    - alpine-3.12-gcc-debug
>  
> -adl-suspend-x86-64-gcc:
> +adl-suspend-x86-64-gcc-debug:
>    extends: .adl-x86-64
>    script:
>      - ./automation/scripts/qubes-x86-64.sh s3 2>&1 | tee ${LOGFILE}
>    needs:
>      - *x86-64-test-needs
> -    - alpine-3.12-gcc
> +    - alpine-3.12-gcc-debug
>  
>  qemu-smoke-dom0-arm64-gcc:
>    extends: .qemu-arm64
> -- 
> 2.39.2
> 
Re: [PATCH] automation: switch ADL hw tests to debug build
Posted by Andrew Cooper 1 year ago
On 13/04/2023 1:23 pm, Marek Marczykowski-Górecki wrote:
> This should give a lot more useful information in case of a failure, and
> also enable some asserts for extra checks.
>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

I'll merge this shortly.