[PATCH 0/7] tools: More Python 3 fixes (part 1 of N)

Andrew Cooper posted 7 patches 1 year, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20230314141520.3652451-1-andrew.cooper3@citrix.com
Test gitlab-ci failed
tools/Rules.mk                       |   2 +-
tools/misc/Makefile                  |   2 -
tools/misc/xencons                   |  92 --------
tools/misc/xencov_split              |   1 -
tools/pygrub/Makefile                |  11 +-
tools/pygrub/src/ExtLinuxConf.py     |   2 +-
tools/pygrub/src/GrubConf.py         |  30 +--
tools/pygrub/src/fsimage/fsimage.c   |   8 +-
tools/pygrub/src/pygrub              |  44 ++--
tools/python/Makefile                |   4 +-
tools/python/pylintrc                | 307 ---------------------------
tools/python/xen/lowlevel/xc/xc.c    | 200 ++++++++---------
tools/python/xen/lowlevel/xs/xs.c    |   4 +-
tools/python/xen/migration/legacy.py |   1 -
tools/python/xen/migration/libxc.py  |   1 -
tools/python/xen/migration/libxl.py  |   1 -
tools/python/xen/migration/public.py |   1 -
tools/python/xen/migration/tests.py  |  15 +-
tools/python/xen/migration/verify.py |   1 -
tools/python/xen/migration/xl.py     |   1 -
tools/python/xen/util.py             |   1 -
tools/xenmon/xenmon.py               |  44 ++--
22 files changed, 177 insertions(+), 596 deletions(-)
delete mode 100755 tools/misc/xencons
delete mode 100644 tools/python/pylintrc
[PATCH 0/7] tools: More Python 3 fixes (part 1 of N)
Posted by Andrew Cooper 1 year, 1 month ago
Despite previous statements to the contrary, Xen still does not support Python 3.

Various notes are on https://gitlab.com/xen-project/xen/-/issues/114

The following scripts are installed, and given a python3 shebang, but are not
Py3 compatible:

  xencov_split
  xentrace_format
  xencons
  xenpvnetboot
  verify-stream-v2
  convert-legacy-stream

Most of these want converting, and should be reasonably easy, but I don't have
time right now.

This series deals with xencons (which is a not-invented-here telnet), various
bits of cleanup, and various fixes for shebangs.

The problematic remaining script is xenpvnetboot which, while looking
reasonably useful and also not PV specific, depends on a 3rd party module but
provides no dependency information at all.

Relatedly, and a critical/blocker for Xen 4.18.  Python 3.12, which will be
released ahead of the Xen 4.18 release, is deleteing distutils (recommending
setuputils as the replacement), so someone is going to have to rework all our
setup.py's to be compatible.

Andrew Cooper (7):
  tools/python: Drop pylintrc
  tools/misc: Drop xencons
  tools: Delete trailing whitespace in python scripts
  tools/pygrub: Factor out common setup.py parts
  tools: Use -s for python shebangs
  tools/python: Improve unit test handling
  tools/python: Drop shebangs from library files

 tools/Rules.mk                       |   2 +-
 tools/misc/Makefile                  |   2 -
 tools/misc/xencons                   |  92 --------
 tools/misc/xencov_split              |   1 -
 tools/pygrub/Makefile                |  11 +-
 tools/pygrub/src/ExtLinuxConf.py     |   2 +-
 tools/pygrub/src/GrubConf.py         |  30 +--
 tools/pygrub/src/fsimage/fsimage.c   |   8 +-
 tools/pygrub/src/pygrub              |  44 ++--
 tools/python/Makefile                |   4 +-
 tools/python/pylintrc                | 307 ---------------------------
 tools/python/xen/lowlevel/xc/xc.c    | 200 ++++++++---------
 tools/python/xen/lowlevel/xs/xs.c    |   4 +-
 tools/python/xen/migration/legacy.py |   1 -
 tools/python/xen/migration/libxc.py  |   1 -
 tools/python/xen/migration/libxl.py  |   1 -
 tools/python/xen/migration/public.py |   1 -
 tools/python/xen/migration/tests.py  |  15 +-
 tools/python/xen/migration/verify.py |   1 -
 tools/python/xen/migration/xl.py     |   1 -
 tools/python/xen/util.py             |   1 -
 tools/xenmon/xenmon.py               |  44 ++--
 22 files changed, 177 insertions(+), 596 deletions(-)
 delete mode 100755 tools/misc/xencons
 delete mode 100644 tools/python/pylintrc

-- 
2.30.2
RE: [PATCH 0/7] tools: More Python 3 fixes (part 1 of N)
Posted by Henry Wang 1 year, 1 month ago
Hi Andrew,

> -----Original Message-----
> From: Andrew Cooper <andrew.cooper3@citrix.com>
> Subject: [PATCH 0/7] tools: More Python 3 fixes (part 1 of N)
> 
> Relatedly, and a critical/blocker for Xen 4.18.  Python 3.12, which will be
> released ahead of the Xen 4.18 release, is deleteing distutils (recommending
> setuputils as the replacement), so someone is going to have to rework all our
> setup.py's to be compatible.

Thanks for noting this, I've taken a note of this issue in my 4.18 release blocker list.

Kind regards,
Henry