[PATCH] tools/xenstore: remove stale comment in create_node()

Juergen Gross posted 1 patch 1 year, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20230220145706.15905-1-jgross@suse.com
Test gitlab-ci failed
There is a newer version of this series
tools/xenstore/xenstored_core.c | 3 ---
1 file changed, 3 deletions(-)
[PATCH] tools/xenstore: remove stale comment in create_node()
Posted by Juergen Gross 1 year, 2 months ago
There is a part of a comment in create_node() which should have been
deleted when modifying the related coding.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/xenstore/xenstored_core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index 7348f935bc..a61db2db2d 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -1480,9 +1480,6 @@ static struct node *create_node(struct connection *conn, const void *ctx,
 	 * All new created nodes will have i->parent set, while the final
 	 * node will be already existing and won't have i->parent set.
 	 * New nodes are subject to quota handling.
-	 * Initially set a destructor for all new nodes removing them from
-	 * TDB again and undoing quota accounting for the case of an error
-	 * during the write loop.
 	 */
 	for (i = node; i; i = i->parent) {
 		/* i->parent is set for each new node, so check quota. */
-- 
2.35.3
Re: [PATCH] tools/xenstore: remove stale comment in create_node()
Posted by Julien Grall 1 year, 2 months ago
Hi,

On 20/02/2023 14:57, Juergen Gross wrote:
> There is a part of a comment in create_node() which should have been
> deleted when modifying the related coding.

IIUC, you are referring to:

1cd3cc7ea27c ("tools/xenstore: create_node: Don't defer work to undo any 
changes on failure").

If so, then please mention it in the commit message. It can be done on 
commit so:

> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall