[PATCH v4 0/3] Memory region overlap check in device tree

Henry Wang posted 3 patches 1 year, 2 months ago
Test gitlab-ci passed
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20230201021513.336837-1-Henry.Wang@arm.com
xen/arch/arm/bootfdt.c           | 13 +++--
xen/arch/arm/efi/efi-boot.h      | 10 +++-
xen/arch/arm/include/asm/setup.h |  2 +
xen/arch/arm/setup.c             | 90 ++++++++++++++++++++++++++++++++
4 files changed, 106 insertions(+), 9 deletions(-)
[PATCH v4 0/3] Memory region overlap check in device tree
Posted by Henry Wang 1 year, 2 months ago
As we are having more and more types of memory region defined in the
device tree, it is necessary to add the overlap check of these memory
regions in Xen, because such check will help user to identify the
misconfiguration in the device tree at the early stage of boot time.

The first patch introduces the basic memory overlap check mechanism,
and does the memory check for memory regions in bootinfo.reserved_mem.
Following patches extend the overlap check to include bootmodules and
EfiACPIReclaimMemory.

v3 -> v4:
1. Correct printk error message, end should be exclusive.
2. Add comment explaining the unhandled case where '*_end' could be 0
   if the module/region is at the end of the physical address space.
3. Add Stefano's reviewed-by tag.

v2 -> v3:
1. Use "[start, end]" format in printk error message.
2. Change the return type of helper functions to bool.
3. Use 'start' and 'size' in helper functions to describe a region.

v1 -> v2:
- Split original `overlap_check()` to `meminfo_overlap_check()` and
  `bootmodules_overlap_check()`.
- Rework commit message.

Henry Wang (3):
  xen/arm: Add memory overlap check for bootinfo.reserved_mem
  xen/arm: Extend the memory overlap check to include bootmodules
  xen/arm: Extend the memory overlap check to include
    EfiACPIReclaimMemory

 xen/arch/arm/bootfdt.c           | 13 +++--
 xen/arch/arm/efi/efi-boot.h      | 10 +++-
 xen/arch/arm/include/asm/setup.h |  2 +
 xen/arch/arm/setup.c             | 90 ++++++++++++++++++++++++++++++++
 4 files changed, 106 insertions(+), 9 deletions(-)

-- 
2.25.1
Re: [PATCH v4 0/3] Memory region overlap check in device tree
Posted by Julien Grall 1 year ago
Hi Henry,

On 01/02/2023 02:15, Henry Wang wrote:
> As we are having more and more types of memory region defined in the
> device tree, it is necessary to add the overlap check of these memory
> regions in Xen, because such check will help user to identify the
> misconfiguration in the device tree at the early stage of boot time.
> 
> The first patch introduces the basic memory overlap check mechanism,
> and does the memory check for memory regions in bootinfo.reserved_mem.
> Following patches extend the overlap check to include bootmodules and
> EfiACPIReclaimMemory.
> 
> v3 -> v4:
> 1. Correct printk error message, end should be exclusive.
> 2. Add comment explaining the unhandled case where '*_end' could be 0
>     if the module/region is at the end of the physical address space.
> 3. Add Stefano's reviewed-by tag.
> 
> v2 -> v3:
> 1. Use "[start, end]" format in printk error message.
> 2. Change the return type of helper functions to bool.
> 3. Use 'start' and 'size' in helper functions to describe a region.
> 
> v1 -> v2:
> - Split original `overlap_check()` to `meminfo_overlap_check()` and
>    `bootmodules_overlap_check()`.
> - Rework commit message.
> 
> Henry Wang (3):
>    xen/arm: Add memory overlap check for bootinfo.reserved_mem
>    xen/arm: Extend the memory overlap check to include bootmodules
>    xen/arm: Extend the memory overlap check to include
>      EfiACPIReclaimMemory

I have committed the series. Sorry for the late.

Cheers,

-- 
Julien Grall