[PATCH for-4.17] x86/spec-ctrl: Fill in whitepaper URL

Andrew Cooper posted 1 patch 3 weeks, 3 days ago
Failed in applying to current master (apply log)
xen/arch/x86/cpu/amd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH for-4.17] x86/spec-ctrl: Fill in whitepaper URL
Posted by Andrew Cooper 3 weeks, 3 days ago
... now that we a link available.

Fixes: 9deaf2d932f0 ("x86/spec-ctrl: Enable Zen2 chickenbit")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Henry Wang <Henry.Wang@arm.com>

For 4.17(?)  Seeing if I can sneak it in as just a documentation change,
seeing as there are others outstanding.  If not, it can go into 4.18 and get
backported.
---
 xen/arch/x86/cpu/amd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c
index 05d72c6501ee..af46d7119bbe 100644
--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -827,7 +827,7 @@ void amd_set_ssbd(bool enable)
  * On Zen2 we offer this chicken (bit) on the altar of Speculation.
  *
  * Refer to the AMD Branch Type Confusion whitepaper:
- * https://XXX
+ * https://www.amd.com/system/files/documents/technical-guidance-for-mitigating-branch-type-confusion.pdf
  *
  * Setting this unnamed bit supposedly causes prediction information on
  * non-branch instructions to be ignored.  It is to be set unilaterally in
-- 
2.11.0


Re: [PATCH for-4.17] x86/spec-ctrl: Fill in whitepaper URL
Posted by Jan Beulich 3 weeks, 2 days ago
On 14.11.2022 22:43, Andrew Cooper wrote:
> ... now that we a link available.
> 
> Fixes: 9deaf2d932f0 ("x86/spec-ctrl: Enable Zen2 chickenbit")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>
RE: [PATCH for-4.17] x86/spec-ctrl: Fill in whitepaper URL
Posted by Henry Wang 3 weeks, 1 day ago
Hi Andrew,

> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Subject: Re: [PATCH for-4.17] x86/spec-ctrl: Fill in whitepaper URL
> 
> On 14.11.2022 22:43, Andrew Cooper wrote:
> > ... now that we a link available.
> >
> > Fixes: 9deaf2d932f0 ("x86/spec-ctrl: Enable Zen2 chickenbit")
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>

Release-acking this seeing scissors line comment from the original
patch "If not, it can go into 4.18 and get backported.". Hopefully
this release-ack will offload some maintenance/backport effort for
x86 maintainers.

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry

Re: [PATCH for-4.17] x86/spec-ctrl: Fill in whitepaper URL
Posted by Andrew Cooper 3 weeks, 1 day ago
On 16/11/2022 11:28, Henry Wang wrote:
> Hi Andrew,
>
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>> Subject: Re: [PATCH for-4.17] x86/spec-ctrl: Fill in whitepaper URL
>>
>> On 14.11.2022 22:43, Andrew Cooper wrote:
>>> ... now that we a link available.
>>>
>>> Fixes: 9deaf2d932f0 ("x86/spec-ctrl: Enable Zen2 chickenbit")
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Acked-by: Jan Beulich <jbeulich@suse.com>
> Release-acking this seeing scissors line comment from the original
> patch "If not, it can go into 4.18 and get backported.". Hopefully
> this release-ack will offload some maintenance/backport effort for
> x86 maintainers.
>
> Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Thanks.

~Andrew