[PATCH v6 01/11] xen/arm: remove xen_phys_start and xenheap_phys_end from config.h

Wei Chen posted 11 patches 3 years, 3 months ago
[PATCH v6 01/11] xen/arm: remove xen_phys_start and xenheap_phys_end from config.h
Posted by Wei Chen 3 years, 3 months ago
These two variables are stale variables, they only have declarations
in config.h, they don't have any definition and no any code is using
these two variables. So in this patch, we remove them from config.h.

Signed-off-by: Wei Chen <wei.chen@arm.com>
---
 xen/arch/arm/include/asm/config.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h
index 0fefed1b8a..25a625ff08 100644
--- a/xen/arch/arm/include/asm/config.h
+++ b/xen/arch/arm/include/asm/config.h
@@ -172,8 +172,6 @@
 #define STACK_SIZE  (PAGE_SIZE << STACK_ORDER)
 
 #ifndef __ASSEMBLY__
-extern unsigned long xen_phys_start;
-extern unsigned long xenheap_phys_end;
 extern unsigned long frametable_virt_end;
 #endif
 
-- 
2.25.1
Re: [PATCH v6 01/11] xen/arm: remove xen_phys_start and xenheap_phys_end from config.h
Posted by Julien Grall 3 years, 3 months ago
Hi,

On 04/11/2022 10:07, Wei Chen wrote:
> These two variables are stale variables, they only have declarations

AFAICT, this has always been the case. I am guessing this was because 
the header was mostly likely copied from x86...

> in config.h, they don't have any definition and no any code is using
> these two variables. So in this patch, we remove them from config.h.
> 
> Signed-off-by: Wei Chen <wei.chen@arm.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall