xen/xsm: dummy.h: Fix MISRA C 2012 Directive 4.10 violation

[PATCH] xen/xsm: dummy.h: Fix MISRA C 2012 Directive 4.10 violation

Posted by Xenia Ragiadakou 1 year, 8 months ago

Protect header file from being included more than once by adding ifndef guard.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
---
 xen/include/xsm/dummy.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
index 77f27e7163..8671af1ba4 100644
--- a/xen/include/xsm/dummy.h
+++ b/xen/include/xsm/dummy.h
@@ -15,6 +15,9 @@
  *  value of action.
  */
 
+#ifndef __XEN_XSM_DUMMY_H__
+#define __XEN_XSM_DUMMY_H__
+
 #include <xen/sched.h>
 #include <xsm/xsm.h>
 #include <public/hvm/params.h>
@@ -843,3 +846,5 @@ static XSM_INLINE int cf_check xsm_domain_resource_map(
     XSM_ASSERT_ACTION(XSM_DM_PRIV);
     return xsm_default_action(action, current->domain, d);
 }
+
+#endif /* __XEN_XSM_DUMMY_H__ */
-- 
2.34.1

Re: [PATCH] xen/xsm: dummy.h: Fix MISRA C 2012 Directive 4.10 violation

Posted by Daniel P. Smith 1 year, 8 months ago

On 7/27/22 11:19, Xenia Ragiadakou wrote:
> Protect header file from being included more than once by adding ifndef guard.
> 
> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
> ---
>   xen/include/xsm/dummy.h | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
> index 77f27e7163..8671af1ba4 100644
> --- a/xen/include/xsm/dummy.h
> +++ b/xen/include/xsm/dummy.h
> @@ -15,6 +15,9 @@
>    *  value of action.
>    */
>   
> +#ifndef __XEN_XSM_DUMMY_H__
> +#define __XEN_XSM_DUMMY_H__
> +
>   #include <xen/sched.h>
>   #include <xsm/xsm.h>
>   #include <public/hvm/params.h>
> @@ -843,3 +846,5 @@ static XSM_INLINE int cf_check xsm_domain_resource_map(
>       XSM_ASSERT_ACTION(XSM_DM_PRIV);
>       return xsm_default_action(action, current->domain, d);
>   }
> +
> +#endif /* __XEN_XSM_DUMMY_H__ */

Acked-by: Daniel P. Smith <dpsmith@apertussolutions.com>

Re: [PATCH] xen/xsm: dummy.h: Fix MISRA C 2012 Directive 4.10 violation

Posted by Luca Fancellu 1 year, 8 months ago


> On 27 Jul 2022, at 16:19, Xenia Ragiadakou <burzalodowa@gmail.com> wrote:
> 
> Protect header file from being included more than once by adding ifndef guard.
> 
> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>

It makes sense!

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>