[PATCH 5/5] xen/arm64: traps: Fix MISRA C 2012 Rule 8.4 violations

Xenia Ragiadakou posted 5 patches 2 years, 5 months ago
There is a newer version of this series
[PATCH 5/5] xen/arm64: traps: Fix MISRA C 2012 Rule 8.4 violations
Posted by Xenia Ragiadakou 2 years, 5 months ago
Add a function prototype for do_bad_mode() in <asm/arm64/traps.h> and include
header <asm/traps.h> in traps.c, so that the declarations of the functions
do_bad_mode() and finalize_instr_emulation(), which have external linkage,
are visible before the function definitions.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
---
 xen/arch/arm/arm64/traps.c             | 1 +
 xen/arch/arm/include/asm/arm64/traps.h | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
index 3f8858acec..a995ad7c2c 100644
--- a/xen/arch/arm/arm64/traps.c
+++ b/xen/arch/arm/arm64/traps.c
@@ -22,6 +22,7 @@
 #include <asm/hsr.h>
 #include <asm/system.h>
 #include <asm/processor.h>
+#include <asm/traps.h>
 
 #include <public/xen.h>
 
diff --git a/xen/arch/arm/include/asm/arm64/traps.h b/xen/arch/arm/include/asm/arm64/traps.h
index 2379b578cb..a347cb13d6 100644
--- a/xen/arch/arm/include/asm/arm64/traps.h
+++ b/xen/arch/arm/include/asm/arm64/traps.h
@@ -6,6 +6,8 @@ void inject_undef64_exception(struct cpu_user_regs *regs, int instr_len);
 void do_sysreg(struct cpu_user_regs *regs,
                const union hsr hsr);
 
+void do_bad_mode(struct cpu_user_regs *regs, int reason);
+
 #endif /* __ASM_ARM64_TRAPS__ */
 /*
  * Local variables:
-- 
2.34.1
Re: [PATCH 5/5] xen/arm64: traps: Fix MISRA C 2012 Rule 8.4 violations
Posted by Bertrand Marquis 2 years, 5 months ago
Hi Xenia,

> On 26 Jun 2022, at 22:11, Xenia Ragiadakou <burzalodowa@gmail.com> wrote:
> 
> Add a function prototype for do_bad_mode() in <asm/arm64/traps.h> and include
> header <asm/traps.h> in traps.c, so that the declarations of the functions
> do_bad_mode() and finalize_instr_emulation(), which have external linkage,
> are visible before the function definitions.
> 
> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>

Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> xen/arch/arm/arm64/traps.c             | 1 +
> xen/arch/arm/include/asm/arm64/traps.h | 2 ++
> 2 files changed, 3 insertions(+)
> 
> diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
> index 3f8858acec..a995ad7c2c 100644
> --- a/xen/arch/arm/arm64/traps.c
> +++ b/xen/arch/arm/arm64/traps.c
> @@ -22,6 +22,7 @@
> #include <asm/hsr.h>
> #include <asm/system.h>
> #include <asm/processor.h>
> +#include <asm/traps.h>
> 
> #include <public/xen.h>
> 
> diff --git a/xen/arch/arm/include/asm/arm64/traps.h b/xen/arch/arm/include/asm/arm64/traps.h
> index 2379b578cb..a347cb13d6 100644
> --- a/xen/arch/arm/include/asm/arm64/traps.h
> +++ b/xen/arch/arm/include/asm/arm64/traps.h
> @@ -6,6 +6,8 @@ void inject_undef64_exception(struct cpu_user_regs *regs, int instr_len);
> void do_sysreg(struct cpu_user_regs *regs,
>                const union hsr hsr);
> 
> +void do_bad_mode(struct cpu_user_regs *regs, int reason);
> +
> #endif /* __ASM_ARM64_TRAPS__ */
> /*
>  * Local variables:
> -- 
> 2.34.1
>