x86/debug: Drop unnecessary include of compile.h

[PATCH] x86/debug: Drop unnecessary include of compile.h

Andrew Cooper posted 1 patch 2 years ago

Download mbox

Test gitlab-ci failed

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20220414090456.10965-1-andrew.cooper3@citrix.com

xen/arch/x86/debug.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[PATCH] x86/debug: Drop unnecessary include of compile.h

Posted by Andrew Cooper 2 years ago

compile.h changes across incremental builds, but nothing in debug.c uses it.
This avoids debug.c getting rebuilt on every incremental build.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/debug.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/arch/x86/debug.c b/xen/arch/x86/debug.c
index d90dc9305697..d16f6e6f8d5d 100644
--- a/xen/arch/x86/debug.c
+++ b/xen/arch/x86/debug.c
@@ -15,7 +15,6 @@
  */
 
 #include <xen/sched.h>
-#include <xen/compile.h>
 #include <xen/mm.h>
 #include <xen/domain_page.h>
 #include <xen/guest_access.h>
-- 
2.11.0

Re: [PATCH] x86/debug: Drop unnecessary include of compile.h

Posted by Jan Beulich 2 years ago

On 14.04.2022 11:04, Andrew Cooper wrote:
> compile.h changes across incremental builds, but nothing in debug.c uses it.
> This avoids debug.c getting rebuilt on every incremental build.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>