[PATCH v2 0/2] xen: Linker scripts synchronization

Michal Orzel posted 2 patches 2 years, 1 month ago
Test gitlab-ci passed
Failed in applying to current master (apply log)
There is a newer version of this series
xen/arch/arm/xen.lds.S    |  38 +++++---------
xen/arch/x86/xen.lds.S    |  79 +++-------------------------
xen/include/xen/xen.lds.h | 108 ++++++++++++++++++++++++++++++++++++++
3 files changed, 129 insertions(+), 96 deletions(-)
create mode 100644 xen/include/xen/xen.lds.h
[PATCH v2 0/2] xen: Linker scripts synchronization
Posted by Michal Orzel 2 years, 1 month ago
This patch series aims to do the first step towards linker scripts
synchronization. Linker scripts for arm and x86 share a lot of common
sections and in order to make the process of changing/improving/syncing
them, these sections shall be defined in just one place.

The first patch creates an empty header file xen.lds.h to store the
constructs mutual to both x86 and arm linker scripts. It also includes
this header in the scripts.

The second patch populates xen.lds.h with the first portion of common
macros and replaces the original contructs with these helpers.

Michal Orzel (2):
  xen: Introduce a header to store common linker scripts content
  xen: Populate xen.lds.h and make use of its macros

 xen/arch/arm/xen.lds.S    |  38 +++++---------
 xen/arch/x86/xen.lds.S    |  79 +++-------------------------
 xen/include/xen/xen.lds.h | 108 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 129 insertions(+), 96 deletions(-)
 create mode 100644 xen/include/xen/xen.lds.h

-- 
2.25.1
Re: [PATCH v2 0/2] xen: Linker scripts synchronization
Posted by Michal Orzel 2 years, 1 month ago
Hi Jan,

Could you please review this series as you did give some comments in v1?

On 22.03.2022 09:02, Michal Orzel wrote:
> This patch series aims to do the first step towards linker scripts
> synchronization. Linker scripts for arm and x86 share a lot of common
> sections and in order to make the process of changing/improving/syncing
> them, these sections shall be defined in just one place.
> 
> The first patch creates an empty header file xen.lds.h to store the
> constructs mutual to both x86 and arm linker scripts. It also includes
> this header in the scripts.
> 
> The second patch populates xen.lds.h with the first portion of common
> macros and replaces the original contructs with these helpers.
> 
> Michal Orzel (2):
>   xen: Introduce a header to store common linker scripts content
>   xen: Populate xen.lds.h and make use of its macros
> 
>  xen/arch/arm/xen.lds.S    |  38 +++++---------
>  xen/arch/x86/xen.lds.S    |  79 +++-------------------------
>  xen/include/xen/xen.lds.h | 108 ++++++++++++++++++++++++++++++++++++++
>  3 files changed, 129 insertions(+), 96 deletions(-)
>  create mode 100644 xen/include/xen/xen.lds.h
> 

Cheers,
Michal
Re: [PATCH v2 0/2] xen: Linker scripts synchronization
Posted by Jan Beulich 2 years, 1 month ago
On 28.03.2022 12:31, Michal Orzel wrote:
> Could you please review this series as you did give some comments in v1?

I have it on my list of things to look at, yes.

Jan

> On 22.03.2022 09:02, Michal Orzel wrote:
>> This patch series aims to do the first step towards linker scripts
>> synchronization. Linker scripts for arm and x86 share a lot of common
>> sections and in order to make the process of changing/improving/syncing
>> them, these sections shall be defined in just one place.
>>
>> The first patch creates an empty header file xen.lds.h to store the
>> constructs mutual to both x86 and arm linker scripts. It also includes
>> this header in the scripts.
>>
>> The second patch populates xen.lds.h with the first portion of common
>> macros and replaces the original contructs with these helpers.
>>
>> Michal Orzel (2):
>>   xen: Introduce a header to store common linker scripts content
>>   xen: Populate xen.lds.h and make use of its macros
>>
>>  xen/arch/arm/xen.lds.S    |  38 +++++---------
>>  xen/arch/x86/xen.lds.S    |  79 +++-------------------------
>>  xen/include/xen/xen.lds.h | 108 ++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 129 insertions(+), 96 deletions(-)
>>  create mode 100644 xen/include/xen/xen.lds.h
>>
> 
> Cheers,
> Michal
>