xen/x86/hvm: add missing cf_check for hvm_physdev_op()

[PATCH] xen/x86/hvm: add missing cf_check for hvm_physdev_op()

Posted by Juergen Gross 2 years, 1 month ago

The hypercall handler hvm_physdev_op() is missing a cf_check attribute.

Fixes: cdbe2b0a1aec ("x86: Enable CET Indirect Branch Tracking")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/arch/x86/hvm/hypercall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c
index 030243810e..62b5349e7d 100644
--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -78,7 +78,7 @@ static long cf_check hvm_grant_table_op(
 }
 #endif
 
-static long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+static long cf_check hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     const struct vcpu *curr = current;
     const struct domain *currd = curr->domain;
-- 
2.34.1

Re: [PATCH] xen/x86/hvm: add missing cf_check for hvm_physdev_op()

Posted by Andrew Cooper 2 years, 1 month ago

On 21/03/2022 07:53, Juergen Gross wrote:
> The hypercall handler hvm_physdev_op() is missing a cf_check attribute.
>
> Fixes: cdbe2b0a1aec ("x86: Enable CET Indirect Branch Tracking")
> Signed-off-by: Juergen Gross <jgross@suse.com>

https://lore.kernel.org/xen-devel/20220309152009.10449-1-andrew.cooper3@citrix.com/

The only reason I haven't committed it is because I was chasing
someone's bug report against compat_vcpu_op()...

~Andrew

> ---
>  xen/arch/x86/hvm/hypercall.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c
> index 030243810e..62b5349e7d 100644
> --- a/xen/arch/x86/hvm/hypercall.c
> +++ b/xen/arch/x86/hvm/hypercall.c
> @@ -78,7 +78,7 @@ static long cf_check hvm_grant_table_op(
>  }
>  #endif
>  
> -static long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
> +static long cf_check hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>  {
>      const struct vcpu *curr = current;
>      const struct domain *currd = curr->domain;

Re: [PATCH] xen/x86/hvm: add missing cf_check for hvm_physdev_op()

Posted by Jan Beulich 2 years, 1 month ago

On 21.03.2022 08:53, Juergen Gross wrote:
> The hypercall handler hvm_physdev_op() is missing a cf_check attribute.
> 
> Fixes: cdbe2b0a1aec ("x86: Enable CET Indirect Branch Tracking")
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>