drivers/block/xen-blkback/blkback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Variable i is being assigned a value that is never read, it is being
re-assigned later in a for-loop. The assignment is redundant and can
be removed.
Cleans up clang scan build warning:
drivers/block/xen-blkback/blkback.c:934:14: warning: Although the value
stored to 'i' is used in the enclosing expression, the value is never
actually read from 'i' [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/block/xen-blkback/blkback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index d1e26461a64e..de42458195bc 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -931,7 +931,7 @@ static int xen_blkbk_parse_indirect(struct blkif_request *req,
if (rc)
goto unmap;
- for (n = 0, i = 0; n < nseg; n++) {
+ for (n = 0; n < nseg; n++) {
uint8_t first_sect, last_sect;
if ((n % SEGS_PER_INDIRECT_FRAME) == 0) {
--
2.35.1
On Thu, Mar 17, 2022 at 11:46:46PM +0000, Colin Ian King wrote: > Variable i is being assigned a value that is never read, it is being > re-assigned later in a for-loop. The assignment is redundant and can > be removed. > > Cleans up clang scan build warning: > drivers/block/xen-blkback/blkback.c:934:14: warning: Although the value > stored to 'i' is used in the enclosing expression, the value is never > actually read from 'i' [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Acked-by: Roger Pau Monné <roger.pau@citrix.com> Thanks, Roger.
On 3/17/22 4:46 PM, Colin Ian King wrote: > Variable i is being assigned a value that is never read, it is being > re-assigned later in a for-loop. The assignment is redundant and can > be removed. > > Cleans up clang scan build warning: > drivers/block/xen-blkback/blkback.c:934:14: warning: Although the value > stored to 'i' is used in the enclosing expression, the value is never > actually read from 'i' [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Looks good. Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> -ck
© 2016 - 2024 Red Hat, Inc.