arch:x86:xen: Remove unnecessary assignment in xen_apic_read()

[PATCH] arch:x86:xen: Remove unnecessary assignment in xen_apic_read()

jianchunfu posted 1 patch 2 years, 8 months ago

Download mbox

Failed in applying to current master (apply log)

arch/x86/xen/apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] arch:x86:xen: Remove unnecessary assignment in xen_apic_read()

Posted by jianchunfu 2 years, 8 months ago

In the function xen_apic_read(), the initialized value of 'ret' is unused
because it will be assigned by the function HYPERVISOR_platform_op(),
thus remove it.

Signed-off-by: jianchunfu <jianchunfu@cmss.chinamobile.com>
---
 arch/x86/xen/apic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c
index 0d46cc283..62d34b661 100644
--- a/arch/x86/xen/apic.c
+++ b/arch/x86/xen/apic.c
@@ -51,7 +51,7 @@ static u32 xen_apic_read(u32 reg)
 		.interface_version = XENPF_INTERFACE_VERSION,
 		.u.pcpu_info.xen_cpuid = 0,
 	};
-	int ret = 0;
+	int ret;
 
 	/* Shouldn't need this as APIC is turned off for PV, and we only
 	 * get called on the bootup processor. But just in case. */
-- 
2.18.4

Re: [PATCH] arch:x86:xen: Remove unnecessary assignment in xen_apic_read()

Posted by Boris Ostrovsky 2 years, 8 months ago

On 3/14/22 3:05 AM, jianchunfu wrote:
> In the function xen_apic_read(), the initialized value of 'ret' is unused
> because it will be assigned by the function HYPERVISOR_platform_op(),
> thus remove it.
>
> Signed-off-by: jianchunfu <jianchunfu@cmss.chinamobile.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>


Applied to for-linus-5.18 (both patches)