x86/hvm: Annotate hvm_physdev_op() with cf_check

[PATCH] x86/hvm: Annotate hvm_physdev_op() with cf_check

Andrew Cooper posted 1 patch 2 years, 1 month ago

Download mbox

Test gitlab-ci passed

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20220309152009.10449-1-andrew.cooper3@citrix.com

xen/arch/x86/hvm/hypercall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] x86/hvm: Annotate hvm_physdev_op() with cf_check

Posted by Andrew Cooper 2 years, 1 month ago

This was missed previously, and would yield a fatal #CP for any HVM domain
which issues a physdevop hypercall.

Reported-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Juergen Gross <jgross@suse.com>
---
 xen/arch/x86/hvm/hypercall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c
index 030243810e48..62b5349e7d6e 100644
--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -78,7 +78,7 @@ static long cf_check hvm_grant_table_op(
 }
 #endif
 
-static long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+static long cf_check hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     const struct vcpu *curr = current;
     const struct domain *currd = curr->domain;
-- 
2.11.0

Re: [PATCH] x86/hvm: Annotate hvm_physdev_op() with cf_check

Posted by Jan Beulich 2 years, 1 month ago

On 09.03.2022 16:20, Andrew Cooper wrote:
> This was missed previously, and would yield a fatal #CP for any HVM domain
> which issues a physdevop hypercall.
> 
> Reported-by: Juergen Gross <jgross@suse.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>