[v3] livepatch: enable -f{function,data}-sections compiler option

[PATCH v3 0/2] livepatch: enable -f{function,data}-sections compiler option

Posted by Roger Pau Monne 2 years, 1 month ago

Hello,

The content in v3 has been split in two patches, but is still mostly the
same. The main difference is that first patch does a bit of cleanup of
the build logic now that the header object file doesn't need to be the
first one passed to the linker script.

Thanks, Roger.

Roger Pau Monne (2):
  xen/build: put image header into a separate section
  livepatch: set -f{function,data}-sections compiler option

 xen/Kconfig                 |  4 +++
 xen/Makefile                |  2 ++
 xen/arch/arm/arch.mk        |  2 --
 xen/arch/arm/arm32/Makefile |  3 +--
 xen/arch/arm/arm32/head.S   |  1 +
 xen/arch/arm/arm64/Makefile |  3 +--
 xen/arch/arm/arm64/head.S   |  1 +
 xen/arch/arm/xen.lds.S      | 49 ++++++++++++++++++++-----------------
 xen/arch/x86/Makefile       |  5 ++--
 xen/arch/x86/arch.mk        |  2 --
 xen/arch/x86/boot/head.S    |  2 +-
 xen/arch/x86/xen.lds.S      | 22 ++++++++++-------
 xen/common/Kconfig          |  1 +
 13 files changed, 54 insertions(+), 43 deletions(-)

-- 
2.34.1

Re: [PATCH v3 0/2] livepatch: enable -f{function,data}-sections compiler option

Posted by Julien Grall 2 years, 1 month ago

Hi,

On 08/03/2022 13:49, Roger Pau Monne wrote:
> Hello,
> 
> The content in v3 has been split in two patches, but is still mostly the
> same. The main difference is that first patch does a bit of cleanup of
> the build logic now that the header object file doesn't need to be the
> first one passed to the linker script.
> 
> Thanks, Roger.
> 
> Roger Pau Monne (2):
>    xen/build: put image header into a separate section
>    livepatch: set -f{function,data}-sections compiler option

For the Arm bits:

Acked-by: Julien Grall <jgrall@amazon.com> # xen/arm

Cheers,

> 
>   xen/Kconfig                 |  4 +++
>   xen/Makefile                |  2 ++
>   xen/arch/arm/arch.mk        |  2 --
>   xen/arch/arm/arm32/Makefile |  3 +--
>   xen/arch/arm/arm32/head.S   |  1 +
>   xen/arch/arm/arm64/Makefile |  3 +--
>   xen/arch/arm/arm64/head.S   |  1 +
>   xen/arch/arm/xen.lds.S      | 49 ++++++++++++++++++++-----------------
>   xen/arch/x86/Makefile       |  5 ++--
>   xen/arch/x86/arch.mk        |  2 --
>   xen/arch/x86/boot/head.S    |  2 +-
>   xen/arch/x86/xen.lds.S      | 22 ++++++++++-------
>   xen/common/Kconfig          |  1 +
>   13 files changed, 54 insertions(+), 43 deletions(-)
> 

-- 
Julien Grall

Re: [PATCH v3 0/2] livepatch: enable -f{function,data}-sections compiler option

Posted by Roger Pau Monné 2 years, 1 month ago

On Tue, Mar 08, 2022 at 02:52:55PM +0000, Julien Grall wrote:
> Hi,
> 
> On 08/03/2022 13:49, Roger Pau Monne wrote:
> > Hello,
> > 
> > The content in v3 has been split in two patches, but is still mostly the
> > same. The main difference is that first patch does a bit of cleanup of
> > the build logic now that the header object file doesn't need to be the
> > first one passed to the linker script.
> > 
> > Thanks, Roger.
> > 
> > Roger Pau Monne (2):
> >    xen/build: put image header into a separate section
> >    livepatch: set -f{function,data}-sections compiler option
> 
> For the Arm bits:
> 
> Acked-by: Julien Grall <jgrall@amazon.com> # xen/arm

Thanks!

I don't think Acks require a scope tag, as you can only Ack changes to
the code you are a maintainer for?

OTOH a 'Reviewed-by:' tag would indeed need to be limited if it only
means to cover xen/arm bits.

In any case I've added the tag as provided to v4.

Roger.

Re: [PATCH v3 0/2] livepatch: enable -f{function,data}-sections compiler option

Posted by Julien Grall 2 years, 1 month ago

Hi Roger,

On 09/03/2022 12:28, Roger Pau Monné wrote:
> On Tue, Mar 08, 2022 at 02:52:55PM +0000, Julien Grall wrote:
>> Hi,
>>
>> On 08/03/2022 13:49, Roger Pau Monne wrote:
>>> Hello,
>>>
>>> The content in v3 has been split in two patches, but is still mostly the
>>> same. The main difference is that first patch does a bit of cleanup of
>>> the build logic now that the header object file doesn't need to be the
>>> first one passed to the linker script.
>>>
>>> Thanks, Roger.
>>>
>>> Roger Pau Monne (2):
>>>     xen/build: put image header into a separate section
>>>     livepatch: set -f{function,data}-sections compiler option
>>
>> For the Arm bits:
>>
>> Acked-by: Julien Grall <jgrall@amazon.com> # xen/arm
> 
> Thanks!
> 
> I don't think Acks require a scope tag, as you can only Ack changes to
> the code you are a maintainer for?

It is not required (same for reviewed-by). But it can be used to specify 
exactly which part you ack.

In this case, I am a maintainer for both common and Arm. I chose to ack 
Arm and leave someone else to confirm the change in common is fine.

Furthermore, with my committer hat on, I find handy to know which person 
acked what. This makes easier to check that the code is suitably acked.

Cheers,

[1] 
https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/process/sending-patches.pandoc;h=7ff7826c992b68804b41cc4a8605329f7a10e44c;hb=refs/heads/staging#l241

-- 
Julien Grall