[PATCH v2 0/5] tools: remove include/xen-external directory

Juergen Gross posted 5 patches 2 years, 2 months ago
Test gitlab-ci failed
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20220207064147.9585-1-jgross@suse.com
There is a newer version of this series
.gitignore                                    |    1 -
tools/include/Makefile                        |    2 +
tools/include/_xen_list.h                     |  509 ++++++++
tools/include/libxl.h                         |    4 +-
tools/include/xen-external/README             |   24 -
tools/include/xen-external/bsd-COPYRIGHT      |  126 --
tools/include/xen-external/bsd-queue.3        | 1044 -----------------
.../xen-external/bsd-sys-queue-h-seddery      |   74 --
tools/include/xen-external/bsd-sys-queue.h    |  637 ----------
tools/include/xentoolcore_internal.h          |    4 +-
tools/libs/evtchn/minios.c                    |   20 +-
tools/libs/light/Makefile                     |   10 +-
tools/libs/light/libxl.c                      |   40 +-
tools/libs/light/libxl_aoutils.c              |   20 +-
tools/libs/light/libxl_device.c               |   27 +-
tools/libs/light/libxl_disk.c                 |    4 +-
tools/libs/light/libxl_domain.c               |   18 +-
tools/libs/light/libxl_event.c                |  128 +-
tools/libs/light/libxl_fork.c                 |   44 +-
tools/libs/light/libxl_internal.h             |   86 +-
tools/libs/light/libxl_qmp.c                  |   19 +-
tools/libs/light/libxl_stream_read.c          |   20 +-
tools/libs/toolcore/Makefile                  |    8 -
23 files changed, 729 insertions(+), 2140 deletions(-)
create mode 100644 tools/include/_xen_list.h
delete mode 100644 tools/include/xen-external/README
delete mode 100644 tools/include/xen-external/bsd-COPYRIGHT
delete mode 100644 tools/include/xen-external/bsd-queue.3
delete mode 100755 tools/include/xen-external/bsd-sys-queue-h-seddery
delete mode 100644 tools/include/xen-external/bsd-sys-queue.h
[PATCH v2 0/5] tools: remove include/xen-external directory
Posted by Juergen Gross 2 years, 2 months ago
The tools/include/xen-external directory contains a header file from
FreeBSD used to generate Xen header files. This series is replacing the
complete directory by a single header with the same semantics.

Changes in V2:
- remove stale comment in patch 1

Juergen Gross (5):
  tools/include: generate a _xen_list.h file
  tools/libs/light: replace _libxl_list.h with _xen_list.h
  tools/libs/toolcore: replace _xentoolcore_list.h with _xen_list.h
  tools/libs/evtchn: use _xen_list.h
  tools/include: remove xen-external directory

 .gitignore                                    |    1 -
 tools/include/Makefile                        |    2 +
 tools/include/_xen_list.h                     |  509 ++++++++
 tools/include/libxl.h                         |    4 +-
 tools/include/xen-external/README             |   24 -
 tools/include/xen-external/bsd-COPYRIGHT      |  126 --
 tools/include/xen-external/bsd-queue.3        | 1044 -----------------
 .../xen-external/bsd-sys-queue-h-seddery      |   74 --
 tools/include/xen-external/bsd-sys-queue.h    |  637 ----------
 tools/include/xentoolcore_internal.h          |    4 +-
 tools/libs/evtchn/minios.c                    |   20 +-
 tools/libs/light/Makefile                     |   10 +-
 tools/libs/light/libxl.c                      |   40 +-
 tools/libs/light/libxl_aoutils.c              |   20 +-
 tools/libs/light/libxl_device.c               |   27 +-
 tools/libs/light/libxl_disk.c                 |    4 +-
 tools/libs/light/libxl_domain.c               |   18 +-
 tools/libs/light/libxl_event.c                |  128 +-
 tools/libs/light/libxl_fork.c                 |   44 +-
 tools/libs/light/libxl_internal.h             |   86 +-
 tools/libs/light/libxl_qmp.c                  |   19 +-
 tools/libs/light/libxl_stream_read.c          |   20 +-
 tools/libs/toolcore/Makefile                  |    8 -
 23 files changed, 729 insertions(+), 2140 deletions(-)
 create mode 100644 tools/include/_xen_list.h
 delete mode 100644 tools/include/xen-external/README
 delete mode 100644 tools/include/xen-external/bsd-COPYRIGHT
 delete mode 100644 tools/include/xen-external/bsd-queue.3
 delete mode 100755 tools/include/xen-external/bsd-sys-queue-h-seddery
 delete mode 100644 tools/include/xen-external/bsd-sys-queue.h

-- 
2.34.1


Re: [PATCH v2 0/5] tools: remove include/xen-external directory
Posted by Anthony PERARD 2 years, 2 months ago
On Mon, Feb 07, 2022 at 07:41:42AM +0100, Juergen Gross wrote:
> The tools/include/xen-external directory contains a header file from
> FreeBSD used to generate Xen header files. This series is replacing the
> complete directory by a single header with the same semantics.
> 
> Changes in V2:
> - remove stale comment in patch 1

Just need to fix the build now, otherwise, the series looks fine:
https://gitlab.com/xen-project/patchew/xen/-/pipelines/464803007
^ xentoolcore conversion seems unfinished.

Thanks,

-- 
Anthony PERARD

Re: [PATCH v2 0/5] tools: remove include/xen-external directory
Posted by Juergen Gross 2 years, 2 months ago
On 07.02.22 19:09, Anthony PERARD wrote:
> On Mon, Feb 07, 2022 at 07:41:42AM +0100, Juergen Gross wrote:
>> The tools/include/xen-external directory contains a header file from
>> FreeBSD used to generate Xen header files. This series is replacing the
>> complete directory by a single header with the same semantics.
>>
>> Changes in V2:
>> - remove stale comment in patch 1
> 
> Just need to fix the build now, otherwise, the series looks fine:
> https://gitlab.com/xen-project/patchew/xen/-/pipelines/464803007
> ^ xentoolcore conversion seems unfinished.

Hmm, weird.

Seems I did only an incremental build, but I think it should have failed
nevertheless. I suspect something is wrong with the dependencies.


Juergen
Re: [PATCH v2 0/5] tools: remove include/xen-external directory
Posted by Anthony PERARD 2 years, 2 months ago
On Tue, Feb 08, 2022 at 06:32:10AM +0100, Juergen Gross wrote:
> On 07.02.22 19:09, Anthony PERARD wrote:
> > On Mon, Feb 07, 2022 at 07:41:42AM +0100, Juergen Gross wrote:
> > > The tools/include/xen-external directory contains a header file from
> > > FreeBSD used to generate Xen header files. This series is replacing the
> > > complete directory by a single header with the same semantics.
> > > 
> > > Changes in V2:
> > > - remove stale comment in patch 1
> > 
> > Just need to fix the build now, otherwise, the series looks fine:
> > https://gitlab.com/xen-project/patchew/xen/-/pipelines/464803007
> > ^ xentoolcore conversion seems unfinished.
> 
> Hmm, weird.
> 
> Seems I did only an incremental build, but I think it should have failed
> nevertheless. I suspect something is wrong with the dependencies.

Indeed, the dependencies aren't loaded. I've prepared a patch:

https://lore.kernel.org/xen-devel/20220208103959.21102-1-anthony.perard@citrix.com/

Thanks,

-- 
Anthony PERARD