The tools/include/xen-external directory contains a header file from
FreeBSD used to generate Xen header files. This series is replacing the
complete directory by a single header with the same semantics.

Juergen Gross (5):
  tools/include: generate a _xen_list.h file
  tools/libs/light: replace _libxl_list.h with _xen_list.h
  tools/libs/toolcore: replace _xentoolcore_list.h with _xen_list.h
  tools/libs/evtchn: use _xen_list.h
  tools/include: remove xen-external directory

 .gitignore                                    |    1 -
 tools/include/Makefile                        |    2 +
 tools/include/_xen_list.h                     |  523 +++++++++
 tools/include/libxl.h                         |    4 +-
 tools/include/xen-external/README             |   24 -
 tools/include/xen-external/bsd-COPYRIGHT      |  126 --
 tools/include/xen-external/bsd-queue.3        | 1044 -----------------
 .../xen-external/bsd-sys-queue-h-seddery      |   74 --
 tools/include/xen-external/bsd-sys-queue.h    |  637 ----------
 tools/include/xentoolcore_internal.h          |    4 +-
 tools/libs/evtchn/minios.c                    |   20 +-
 tools/libs/light/Makefile                     |   10 +-
 tools/libs/light/libxl.c                      |   40 +-
 tools/libs/light/libxl_aoutils.c              |   20 +-
 tools/libs/light/libxl_device.c               |   27 +-
 tools/libs/light/libxl_disk.c                 |    4 +-
 tools/libs/light/libxl_domain.c               |   18 +-
 tools/libs/light/libxl_event.c                |  128 +-
 tools/libs/light/libxl_fork.c                 |   44 +-
 tools/libs/light/libxl_internal.h             |   86 +-
 tools/libs/light/libxl_qmp.c                  |   19 +-
 tools/libs/light/libxl_stream_read.c          |   20 +-
 tools/libs/toolcore/Makefile                  |    8 -
 23 files changed, 743 insertions(+), 2140 deletions(-)
 create mode 100644 tools/include/_xen_list.h
 delete mode 100644 tools/include/xen-external/README
 delete mode 100644 tools/include/xen-external/bsd-COPYRIGHT
 delete mode 100644 tools/include/xen-external/bsd-queue.3
 delete mode 100755 tools/include/xen-external/bsd-sys-queue-h-seddery
 delete mode 100644 tools/include/xen-external/bsd-sys-queue.h

-- 
2.31.1

On Sun, Jan 30, 2022 at 09:43:38AM +0100, Juergen Gross wrote:
> The tools/include/xen-external directory contains a header file from
> FreeBSD used to generate Xen header files. This series is replacing the
> complete directory by a single header with the same semantics.
> 
> Juergen Gross (5):
>   tools/libs/light: replace _libxl_list.h with _xen_list.h
>   tools/libs/toolcore: replace _xentoolcore_list.h with _xen_list.h
>   tools/libs/evtchn: use _xen_list.h
>   tools/include: remove xen-external directory
> 
>  tools/include/_xen_list.h                     |  523 +++++++++
>  tools/include/libxl.h                         |    4 +-

Hi,

While this looks like a good cleanup, I'm not sure whether this is a
good idea with regards to the change in libxl's public headers.

The LIBXL_TAILQ_* macro are exposed via libxl.h, and it seems that using
`libxl_event.link` is explicitly allowed (via "libxl_types.idl") to make
a list of event in a application. But there isn't really a reason to use
the macro.

I didn't find any use of the macros in libvirt, so maybe it's fine to
change it?

What do people think?

Cheers,

-- 
Anthony PERARD

On 02.02.22 12:53, Anthony PERARD wrote:
> On Sun, Jan 30, 2022 at 09:43:38AM +0100, Juergen Gross wrote:
>> The tools/include/xen-external directory contains a header file from
>> FreeBSD used to generate Xen header files. This series is replacing the
>> complete directory by a single header with the same semantics.
>>
>> Juergen Gross (5):
>>    tools/libs/light: replace _libxl_list.h with _xen_list.h
>>    tools/libs/toolcore: replace _xentoolcore_list.h with _xen_list.h
>>    tools/libs/evtchn: use _xen_list.h
>>    tools/include: remove xen-external directory
>>
>>   tools/include/_xen_list.h                     |  523 +++++++++
>>   tools/include/libxl.h                         |    4 +-
> 
> Hi,
> 
> While this looks like a good cleanup, I'm not sure whether this is a
> good idea with regards to the change in libxl's public headers.
> 
> The LIBXL_TAILQ_* macro are exposed via libxl.h, and it seems that using
> `libxl_event.link` is explicitly allowed (via "libxl_types.idl") to make
> a list of event in a application. But there isn't really a reason to use
> the macro.
> 
> I didn't find any use of the macros in libvirt, so maybe it's fine to
> change it?
> 
> What do people think?

If thought to be needed I could still add the LIBXL_TAILQ_* macros
to libxl.h by defining them as aliases of the XEN_TAILQ_* macros.


Juergen