fix wrong function declaration

[PATCH] fix wrong function declaration

Posted by Juergen Gross 2 years, 3 months ago

Coverity spotted a wrong function declaration, fix it.

Coverity-Id: 1497423
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 include/balloon.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/balloon.h b/include/balloon.h
index 8f7c8bd8..510e475a 100644
--- a/include/balloon.h
+++ b/include/balloon.h
@@ -50,7 +50,7 @@ static inline int chk_free_pages(unsigned long needed)
 {
     return needed <= nr_free_pages;
 }
-static inline balloon_set_nr_pages(unsigned long pages, unsigned long pfn) { }
+static inline void balloon_set_nr_pages(unsigned long pages, unsigned long pfn) { }
 
 #endif /* CONFIG_BALLOON */
 #endif /* _BALLOON_H_ */
-- 
2.31.1

Re: [PATCH] fix wrong function declaration

Posted by Bertrand Marquis 2 years, 3 months ago

Hi Juergen,

> On 19 Jan 2022, at 13:06, Juergen Gross <jgross@suse.com> wrote:
> 
> Coverity spotted a wrong function declaration, fix it.
> 
> Coverity-Id: 1497423
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> include/balloon.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/balloon.h b/include/balloon.h
> index 8f7c8bd8..510e475a 100644
> --- a/include/balloon.h
> +++ b/include/balloon.h
> @@ -50,7 +50,7 @@ static inline int chk_free_pages(unsigned long needed)
> {
>     return needed <= nr_free_pages;
> }
> -static inline balloon_set_nr_pages(unsigned long pages, unsigned long pfn) { }
> +static inline void balloon_set_nr_pages(unsigned long pages, unsigned long pfn) { }
> 
> #endif /* CONFIG_BALLOON */
> #endif /* _BALLOON_H_ */
> -- 
> 2.31.1
> 
>